-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Python 3.7 #11408
Require Python 3.7 #11408
Conversation
We could use some wider eyes on this one. Pinging people who have contributed some of the niche OS support: @BlitzKraft @chax @csssuf @manuel-arguelles @petejohanson @shieldsd @skewwhiffy @umanwizard @zjp |
Per https://www.gentoo.org/support/news-items/2020-04-22-python3-7.html Python 3.7 is now the default python version on Gentoo, so I think this is OK. |
It looks good to me. Sabayon is rebranding to mocaccinoOS. I am not sure if it is relevant. Is it possible to have the installer skip the uname check and have it use a generic tool with some warning? For example all debian based distros can use apt. So, check for an env variable, say, The reason I mention this is because of the sabayon rebranding, as well as covering as many use cases as possible without having to account for the name of each distro uname string. User from elementary/popOS/zorin etc can set variable to debian, and the installer does its thing. Edit: This is in addition to the current checks. Not a replacement. If the env var is not found/invalid, the install proceeds as it does in the current state. |
As long as Edit: this works today on raspbian (source: I compile qmk on a pi occasionally) |
sabayon has a different package manager. Hence the need for the separate script. ID_LIKE is not guaranteed to be present, is it? |
We check both The use case you describe is already handled by |
Solus currently uses pyrhon 3.7.9 as main python3 version, and since Solus is rolling release distro, version will only go up. You can see current version here: https://dev.getsol.us/source/python3/ Do you need me to test this PR? |
If you're confident it works fine there's no need to test now. There will be time to test all of |
Description
Bump our required Python version to 3.7. This also removes support for linux distributions which are currently broken.
Types of Changes
Checklist