Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up QWIIC makefile variables to have _ENABLE and _DRIVERS #11426

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 3, 2021

Description

As per the description, this splits up QWIIC_ENABLE=<drivers> to both QWIIC_ENABLE=yes/no and QWIIC_DRIVERS=<drivers>.
This is broken on develop since the addition of qmk generate-rules-mk.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team January 3, 2021 21:32
@skullydazed skullydazed requested a review from a team January 3, 2021 21:43
@tzarc tzarc merged commit 34446b7 into qmk:develop Jan 3, 2021
@tzarc tzarc deleted the split-qwiic_enable-drivers branch January 3, 2021 21:45
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants