Lighting Layers should be disabled when suspended #11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jan 5, 2021
fauxpark
approved these changes
Jan 5, 2021
14 tasks
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 2, 2021
* Lighting Layers should be disabled when suspended * bugfixes
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Lighting Layers should be disabled when suspended * bugfixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of RGBLIGHT_SLEEP does not disable lighting layers on suspend if RGBLIGHT_LAYERS_OVERRIDE_RGB_OFF is defined. This was an oversight when it was originally implemented, resolved in this pull request.
I have also refactored RGBLIGHT_SLEEP somewhat to eliminate some duplicate code, and to improve encapsulation.
This change does not incur any significant change in compiled firmware size.
Types of Changes
Checklist