Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to add data driven configurations #11502

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Document how to add data driven configurations #11502

merged 2 commits into from
Jan 11, 2021

Conversation

skullydazed
Copy link
Member

Description

This describes how to add configuration values to info.json so they work in the build system as well.

Types of Changes

  • Core
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@skullydazed skullydazed requested a review from a team January 10, 2021 17:35
ridingqwerty
ridingqwerty reviewed Jan 10, 2021
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor readability fixups.

docs/data_driven_config.md Outdated Show resolved Hide resolved
docs/data_driven_config.md Outdated Show resolved Hide resolved
docs/data_driven_config.md Outdated Show resolved Hide resolved
Erovia
Erovia approved these changes Jan 10, 2021
View reviewed changes
docs/data_driven_config.md Outdated Show resolved Hide resolved
@Erovia Erovia requested a review from a team January 10, 2021 17:57
@skullydazed @ridingqwerty @Erovia
Apply suggestions from code review
bd8f369 
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@skullydazed skullydazed merged commit a15c905 into develop Jan 11, 2021
@skullydazed skullydazed deleted the data_driven_config branch January 11, 2021 04:48
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed @ridingqwerty @Erovia
Document how to add data driven configurations (qmk#11502)
19cdaa0 
* describe how data driven configuration works

* Apply suggestions from code review

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty left review comments

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @Erovia @ridingqwerty