-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UART driver refactor #11637
Merged
Merged
UART driver refactor #11637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working on AVR (tested Pro Micro), Bluepill F103, and Proton-C, though for the latter, USART2 is actually enabled by default, despite the fact that A9 and A10 (labelled TX and RX on the pinout)'s AFs are RX/TX for USART1. Should I change this? |
This matches up with A9/A10 as TX/RX on the pinout
tzarc
reviewed
Jan 21, 2021
tzarc
approved these changes
Jan 21, 2021
tzarc
requested changes
Jan 21, 2021
tzarc
approved these changes
Jan 21, 2021
drashna
approved these changes
Jan 22, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the existing
uart.[ch]
driver todrivers/
, and adds a ChibiOS counterpart (which may need some QA from someone more versed in the ARM side of things).It would also be good to get some
puts()
andgets()
implementations added, if possible. And I'm not really sure what to do withuart_available()
on ARM.Types of Changes
Issues Fixed or Closed by This PR
Checklist