Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART driver refactor #11637

Merged
merged 8 commits into from
Jan 27, 2021
Merged

UART driver refactor #11637

merged 8 commits into from
Jan 27, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 20, 2021

Description

Moves the existing uart.[ch] driver to drivers/, and adds a ChibiOS counterpart (which may need some QA from someone more versed in the ARM side of things).

It would also be good to get some puts() and gets() implementations added, if possible. And I'm not really sure what to do with uart_available() on ARM.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member Author

fauxpark commented Jan 20, 2021

Working on AVR (tested Pro Micro), Bluepill F103, and Proton-C, though for the latter, USART2 is actually enabled by default, despite the fact that A9 and A10 (labelled TX and RX on the pinout)'s AFs are RX/TX for USART1. Should I change this?

drivers/chibios/uart.c Outdated Show resolved Hide resolved
docs/uart_driver.md Outdated Show resolved Hide resolved
docs/uart_driver.md Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team January 21, 2021 11:14
@fauxpark fauxpark merged commit 30b46fa into qmk:develop Jan 27, 2021
@fauxpark fauxpark deleted the uart-driver branch January 27, 2021 06:42
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants