Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mousekey to quantum #11804

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 5, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team February 5, 2021 18:53
@github-actions github-actions bot added the core label Feb 5, 2021
@zvecr zvecr force-pushed the feature/mousekeys_move branch from 386d9be to 0f1b104 Compare February 7, 2021 13:53
@zvecr zvecr merged commit 0288142 into qmk:develop Feb 7, 2021
@uqs
Copy link

uqs commented Mar 14, 2021

This broke my build.

Compiling: quantum/mousekey.c                                                                      quantum/mousekey.c: In function ‘move_unit’:
quantum/mousekey.c:135:35: error: ‘mouse_timer’ undeclared (first use in this function)
  135 |     } else if (mousekey_repeat && mouse_timer) {
      |                                   ^~~~~~~~~~~
quantum/mousekey.c:135:35: note: each undeclared identifier is reported only once for each function it appears in
quantum/mousekey.c: At top level:
quantum/mousekey.c:149:7: error: conflicting types for ‘mk_wheel_interval’
  149 | float mk_wheel_interval = 1000.0f / MOUSEKEY_WHEEL_INITIAL_MOVEMENTS;
      |       ^~~~~~~~~~~~~~~~~
quantum/mousekey.c:68:9: note: previous definition of ‘mk_wheel_interval’ was here
   68 | uint8_t mk_wheel_interval    = MOUSEKEY_WHEEL_INTERVAL;
      |         ^~~~~~~~~~~~~~~~~
quantum/mousekey.c: In function ‘wheel_unit’:
quantum/mousekey.c:156:35: error: ‘mouse_timer’ undeclared (first use in this function)
  156 |     } else if (mousekey_repeat && mouse_timer) {
      |                                   ^~~~~~~~~~~
 [ERRORS]

mouse_timer is only declared under ifdef MK_KINETIC_SPEED but then later used indiscriminately. Easy enough to fix. But the other error is more problematic. In any case, my mouse cursor speed is now absolutely effed.

My config was working fine before:

// KC_ACL0 et al work when held.                                                                       
#define MK_COMBINED
#define MOUSEKEY_WHEEL_INTERVAL 30                                                                     

@uqs
Copy link

uqs commented Mar 14, 2021

Filed issue#12241 so this comment doesn't get lost.

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants