Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor platform logic within print.h #11863

Merged
merged 9 commits into from
Feb 14, 2021
Merged

Refactor platform logic within print.h #11863

merged 9 commits into from
Feb 14, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 11, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 11, 2021
@zvecr zvecr force-pushed the feature/unify_logging2 branch from 923f0c7 to 6175003 Compare February 12, 2021 23:02
fauxpark
fauxpark requested changes Feb 13, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer not to use CamelCase for the function pointer type, but otherwise looks nice.

tmk_core/protocol/vusb/main.c Outdated Show resolved Hide resolved
@zvecr zvecr marked this pull request as ready for review February 13, 2021 16:20
@zvecr zvecr requested review from fauxpark and a team February 13, 2021 16:20
tzarc
tzarc approved these changes Feb 14, 2021
View reviewed changes
tmk_core/common/printf.c Outdated Show resolved Hide resolved
zvecr and others added 2 commits February 14, 2021 00:51
@zvecr @tzarc
Update tmk_core/common/printf.c
43b5eaf 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@zvecr
Format
9576fad
@zvecr zvecr merged commit 1f2fe2e into qmk:develop Feb 14, 2021
@zvecr zvecr mentioned this pull request Mar 17, 2021
Merged
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr @tzarc
Refactor platform logic within print.h (qmk#11863)
70fddfd 
* Remove GCC check from debug

* Remove platform logic from common.mk

* Refactor platform logic within print.h

* restore debug.c format

* headers

* Rename function pointer type

* review comments

* Update tmk_core/common/printf.c

Co-authored-by: Nick Brassel <nick@tzarc.org>

* Format

Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark