Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hid_listen subcommand #11923

Closed
wants to merge 9 commits into from
Closed

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 15, 2021

Description

TODO:

  • docs
  • vid/pid filter?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Feb 15, 2021
@github-actions github-actions bot added the CI label Feb 15, 2021
@zvecr zvecr added the feature label Feb 15, 2021
@zvecr
Copy link
Member Author

zvecr commented Feb 16, 2021

Seems 'asyncio' sucks on windows, does not recognize ctrl+c, so needs a rewrite... yay!

Edit: seems its more that msys/mintty https://github.com/msys2/MINGW-packages/issues/7111

Edit2: so it now functions correctly....

  • on windows if you use something like cmd or Windows Terminal
  • on linux if it gets non zero usage/usage page

Also added a basic device filter, though im not sure if --device 4b50:016a is better than --pid 4b50 --vid 016a?

@zvecr zvecr marked this pull request as ready for review February 25, 2021 22:49
@stale
Copy link

stale bot commented Apr 18, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@zvecr
Copy link
Member Author

zvecr commented May 8, 2021

#12828

@zvecr zvecr closed this May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants