Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LAYOUT parsing more robust #12000

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Make LAYOUT parsing more robust #12000

merged 1 commit into from
Feb 25, 2021

Conversation

skullydazed
Copy link
Member

Description

As reported by spidey3 this makes the layout processing more robust in the face of trailing commas.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Feb 24, 2021
@skullydazed skullydazed requested a review from a team February 24, 2021 18:38
@skullydazed skullydazed requested a review from a team February 24, 2021 19:48
@skullydazed skullydazed merged commit 23ef327 into develop Feb 25, 2021
@skullydazed skullydazed deleted the fix_stracktrace branch February 25, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @drashna @fauxpark