-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency check of MATRIX size against the number of defined pins #12151
Conversation
Thank you for your contribution! |
@@ -29,10 +29,37 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
#define ROWS_PER_HAND (MATRIX_ROWS / 2) | |||
|
|||
#ifdef DIRECT_PINS | |||
# ifdef DIRECT_PINS_RIGHT | |||
static pin_t direct_pins[MATRIX_ROWS][MATRIX_COLS] = DIRECT_PINS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also be a const?
Thank you for your contribution! |
Could you retarget this to develop, and rebase? There are some changes in develop that will have conflicts with this change, though. |
Thank you for your contribution! |
Thank you for your contribution! |
Description
This is the refined version of the consistency check patch which was included in #8160 .
It properly handles those keyboards doing things a bit off track.
keyboards/ai03/voyager60_alps
MATRIX_COLS and MATRIX_COL_PINS contradicts. but it will be handled safely.
keyboards/choco60/rev2
number of COL pins differ between left side and right side. but it will be handled safely.
Following is the only one which needs treatment.
keyboards/for_science
need SPLIT_KEYBOARD = yes
I've checked this is not increasing binary size for any of the keyboards except choco60/rev2 .
Types of Changes
Checklist