-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the exclusions of key presses to not actuate the haptic feedback #12386
Conversation
Implementation for exclusion keys for the haptic feedback with the option to activate / de-activate a standard set and define own exclusion keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected incorrect formatting
I am also interested in getting this change through. |
This should be a define, not part of the rules.mk stuff. Additionally, would rather a |
Moved the key exclusion in haptic.c into its own function
Function exclude_haptic_key contains the evaluation for firing the feedback. This includes the default exclusions and the possible self defined keys.
Code has been cleaned up and adjusted to QMK coding style
Indentation corrected
Indentation style
@drashna The requested changes have been implemented (function that determines the keys to exclude and removed the rules.mk portion). |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna Great recommendations! I have committed all changes and tested it against the haptic feedback against all option variations. Only change I'd suggest is to #define HAPTIC_EXCLUSION_KEY_DEFAULT(keycode, tapcount) for consistency in the documentation. |
Re-implementation as function - entries in config.h have changed
Implemented as function. The changes have been adjusted to use the implementation style in other areas of QMK. Since the previous implementation, the way of exclusions have changed and this was also reflected on the doc accordingly.
@drashna Huge thanks for the guidance. I have re-implemented it according the other areas. Tests have been run against all options with a Solenoid. |
Could this target develop, actually? |
n/m, I've done it. And thanks! |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Description
With the entry of
HAPTIC_EXCLUSION_KEYS 1
in config.h exclusion keys can be enabled.By default they contain modifier and layer keys, which won't activate the haptic feedback, if set.
Additional keys can be added in config.h in a comma separated list in the form of:
#define HAPTIC_EXCLUSION_KEY_ADDITIONAL { KC_A, KC_B, KC_C }
In case it is desired to exclude only the self-defined and comma-separated list (without having the modifier and layer keys excluded), it can be achieved by turning off the default set in config.h:
#define HAPTIC_EXCLUSION_KEY_DEFAULT(keycode) 0
Types of Changes
Issues Fixed or Closed by This PR
Checklist