Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] Add kzar keymap for Kinesis Advantage #12444

Merged
merged 1 commit into from
Apr 13, 2021
Merged

[Keymap] Add kzar keymap for Kinesis Advantage #12444

merged 1 commit into from
Apr 13, 2021

Conversation

kzar
Copy link

@kzar kzar commented Mar 31, 2021

Description

Now that support for the kinesis/kint36 had landed (9d3b11d), I would like to add my keyboard map for it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@kzar
Copy link
Author

kzar commented Mar 31, 2021

Cc @stapelberg

stapelberg
stapelberg reviewed Mar 31, 2021
View reviewed changes
keyboards/kinesis/keymaps/kzar/rules.mk Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/kzar/config.h Outdated Show resolved Hide resolved
@kzar kzar force-pushed the kint36-keymap-kzar branch from 6c2030f to c36f06e Compare March 31, 2021 12:21
fauxpark
fauxpark requested changes Mar 31, 2021
View reviewed changes
keyboards/kinesis/keymaps/kzar/keymap.c Outdated Show resolved Hide resolved
keyboards/kinesis/keymaps/kzar/keymap.c Outdated Show resolved Hide resolved
@kzar kzar force-pushed the kint36-keymap-kzar branch 3 times, most recently from dbfa5df to 902adf3 Compare March 31, 2021 17:14
@fauxpark fauxpark requested a review from a team March 31, 2021 18:32
@kzar kzar force-pushed the kint36-keymap-kzar branch from 902adf3 to fef8d5d Compare April 3, 2021 10:15
@kzar
Copy link
Author

kzar commented Apr 7, 2021

Any chance you could take a second look @drashna? I'm hoping with those license headers this should be good to go.

@kzar kzar force-pushed the kint36-keymap-kzar branch from fef8d5d to a0ca272 Compare April 9, 2021 12:20
@Erovia Erovia merged commit 15f7cc3 into qmk:develop Apr 13, 2021
@kzar
Copy link
Author

kzar commented Apr 13, 2021

Thanks everyone 🎉 🎈

@drashna drashna mentioned this pull request May 22, 2021
Closed
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@kzar @nhongooi
[Keymap] Add kzar keymap for Kinesis Advantage (qmk#12444)
0337272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stapelberg stapelberg stapelberg approved these changes

@drashna drashna drashna requested changes

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kzar @stapelberg @drashna @Erovia @fauxpark