Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eeprom_i2c driver: added EXTERNAL_EEPROM_WP_PIN configuration option. #12617

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

purdeaandrei
Copy link
Contributor

Description

This is for boards that follow eeprom manufacturer recommendations,
to not hardcode the WP pin, but to deassert it only during writes,
to protect eeprom content during power-up/power-down/brown-out conditions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team April 25, 2021 20:50
@drashna
Copy link
Member

drashna commented May 9, 2021

This should also probably target develop.

@purdeaandrei purdeaandrei changed the base branch from master to develop June 21, 2021 19:11
This is for boards that follow eeprom manufacturer recommendations,
to not hardcode the WP pin, but to deassert it only during writes,
to protect eeprom content during power-up/power-down/brown-out conditions.
…the pin value to 1, to make sure there are at least two bit-flips that are needed to change the pin back to 0
@purdeaandrei purdeaandrei force-pushed the f_i2c_eeprom_wp_pin branch from 50b8705 to 2547b07 Compare June 21, 2021 19:13
@purdeaandrei
Copy link
Contributor Author

Rebased to develop

@drashna drashna merged commit dd16d3c into qmk:develop Jun 22, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@purdeaandrei purdeaandrei deleted the f_i2c_eeprom_wp_pin branch September 10, 2022 09:39
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants