Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sethBarberee Userspace #12620

Merged
merged 14 commits into from
May 8, 2021
Merged

Update sethBarberee Userspace #12620

merged 14 commits into from
May 8, 2021

Conversation

SethBarberee
Copy link
Contributor

Description

  • Did a large overhaul on my userspace to account for my shift from Iris to Sinc.
  • Unified all my RGB/Tap Dance work into my userspace
  • Doing a little prep in my userspace for a crkbd that I keep putting off.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@SethBarberee
update for LTO and guard RGBLED_SPLIT
ce81177
@SethBarberee
Revert "update for LTO and guard RGBLED_SPLIT"
67da0ce 
This reverts commit ce81177.
@SethBarberee
Revert "Revert "update for LTO and guard RGBLED_SPLIT""
04f40ae 
This reverts commit 67da0ce.
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
04c64bb
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
d005886
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
f5e2d1b
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware into master
27ee312
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
c2b9efd
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
8f6a424
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
2fa78de
@SethBarberee
Merge branch 'master' of https://github.com/qmk/qmk_firmware
e997fa7
@SethBarberee
update iris keymap for keymap_kc removal and overhaul userspace
e5e1316
@SethBarberee
Copy link
Contributor Author

Errors out bc of keebio/sinc/rev1/config.h using the RGBLIGHT_MODE_RAINBOW_SWIRL define. I turn off RGBLIGHT_ANIMATIONS so causes the error. RGBLIGHT_DEFAULT_MODE isn't used anymore since #12138. Would it be fine if I attached a patch to my PR fixing that for both Rev 1 and 2 Sinc?

drashna
drashna requested changes Apr 20, 2021
View reviewed changes
keyboards/keebio/iris/keymaps/sethBarberee/config.h Outdated Show resolved Hide resolved
keyboards/keebio/sinc/keymaps/sethBarberee/config.h Outdated Show resolved Hide resolved
keyboards/keebio/sinc/keymaps/sethBarberee/keymap.c Outdated Show resolved Hide resolved
users/sethBarberee/config.h Show resolved Hide resolved
users/sethBarberee/rgb_light.c Show resolved Hide resolved
users/sethBarberee/sethBarberee.c Show resolved Hide resolved
users/sethBarberee/sethBarberee.h Show resolved Hide resolved
users/sethBarberee/tap_dance.c Show resolved Hide resolved
users/sethBarberee/tap_dance.h Show resolved Hide resolved
users/sethBarberee/wrappers.h Show resolved Hide resolved
@SethBarberee
Copy link
Contributor Author

Updated and addressed comments. Would appreciate opinion on the sinc build issue and whether I can include the patch for that build issue.

@SethBarberee SethBarberee requested a review from drashna May 2, 2021 00:27
@skullydazed skullydazed requested a review from a team May 8, 2021 16:39
fauxpark
fauxpark approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, but it is recommended to lowercase your keymap & userspace names.

@skullydazed skullydazed merged commit b7fe249 into qmk:master May 8, 2021
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@SethBarberee @rizo
Update sethBarberee Userspace (qmk#12620)
21c79b5 
* update for LTO and guard RGBLED_SPLIT

* Revert "update for LTO and guard RGBLED_SPLIT"

This reverts commit ce81177.

* Revert "Revert "update for LTO and guard RGBLED_SPLIT""

This reverts commit 67da0ce.

* update iris keymap for keymap_kc removal and overhaul userspace

* add licenses

* fix tap_dance error when rgblight is disabled and update/clean iris/sinc maps
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@SethBarberee @toddyamakawa
Update sethBarberee Userspace (qmk#12620)
8c73500 
* update for LTO and guard RGBLED_SPLIT

* Revert "update for LTO and guard RGBLED_SPLIT"

This reverts commit ce81177.

* Revert "Revert "update for LTO and guard RGBLED_SPLIT""

This reverts commit 67da0ce.

* update iris keymap for keymap_kc removal and overhaul userspace

* add licenses

* fix tap_dance error when rgblight is disabled and update/clean iris/sinc maps
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@SethBarberee @HokieGeek
Update sethBarberee Userspace (qmk#12620)
3da68fa 
* update for LTO and guard RGBLED_SPLIT

* Revert "update for LTO and guard RGBLED_SPLIT"

This reverts commit ce81177.

* Revert "Revert "update for LTO and guard RGBLED_SPLIT""

This reverts commit 67da0ce.

* update iris keymap for keymap_kc removal and overhaul userspace

* add licenses

* fix tap_dance error when rgblight is disabled and update/clean iris/sinc maps
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@SethBarberee
Update sethBarberee Userspace (qmk#12620)
bf4c5f6 
* update for LTO and guard RGBLED_SPLIT

* Revert "update for LTO and guard RGBLED_SPLIT"

This reverts commit ce81177.

* Revert "Revert "update for LTO and guard RGBLED_SPLIT""

This reverts commit 67da0ce.

* update iris keymap for keymap_kc removal and overhaul userspace

* add licenses

* fix tap_dance error when rgblight is disabled and update/clean iris/sinc maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SethBarberee @drashna @fauxpark @skullydazed