Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user override of RGB_DISABLE_WHEN_USB_SUSPENDED for BM40 keyboard #12700

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Allow user override of RGB_DISABLE_WHEN_USB_SUSPENDED for BM40 keyboard #12700

merged 3 commits into from
Jun 16, 2021

Conversation

filterpaper
Copy link
Contributor

Description

Allow user override to the RGB_DISABLE_WHEN_USB_SUSPENDED setting, based on @tzarc's suggestion in #12290

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team April 26, 2021 04:16
@stale
Copy link

stale bot commented Jun 11, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@filterpaper
Copy link
Contributor Author

@tzarc Can you help add the appropriate label to avoid re-flagging while awaiting other reviewers? Thanks.

@fauxpark
Copy link
Member

See #13146

I think the correct way to override this define now (in develop) is to just #undef it if it's defined, and #define it if it's not.

@stale stale bot removed the awaiting changes label Jun 11, 2021
@filterpaper @drashna
Update logic to suggested change.
c2cf4e9 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna
Copy link
Member

drashna commented Jun 16, 2021

Thanks!

@drashna drashna merged commit abee061 into qmk:master Jun 16, 2021
@filterpaper filterpaper deleted the bm40_rgbdisable branch June 16, 2021 05:40
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@filterpaper @drashna @HokieGeek
[Keyboard] Allow user override of RGB_DISABLE_WHEN_USB_SUSPENDED for …
9843c0b 
…BM40 keyboard (qmk#12700)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@filterpaper @drashna @wox
[Keyboard] Allow user override of RGB_DISABLE_WHEN_USB_SUSPENDED for …
bd7b638 
…BM40 keyboard (qmk#12700)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@filterpaper @drashna @nhongooi
[Keyboard] Allow user override of RGB_DISABLE_WHEN_USB_SUSPENDED for …
a6c955f 
…BM40 keyboard (qmk#12700)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filterpaper @fauxpark @drashna @tzarc