Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readPort() and some API to 'tmk_core/common/*/gpio.h' #12754

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Apr 30, 2021

Description

The following macros have been added to gpio.h.

  • readPort(port)
  • setPortBitInput(port, bit)
  • setPortBitInputHigh(port, bit)
  • setPortBitOutput(port, bit)
  • writePortBitLow(port, bit)
  • writePortBitHigh(port, bit)
Effects of using `readPort()`. (click)

Pro Micro, current matrix.c (MATRIX_IO_DELAY=0)

  • Processing time for Row0: 75.2us

DS1Z_QuickPrint38

Pro Micro, optimized the reading procedure using 'readPort()'.

  • Processing time for Row0: 12.8us

DS1Z_QuickPrint37

Proton C, current matrix.c (MATRIX_IO_DELAY=0)

  • Processing time for Row0: 14.2us

DS1Z_QuickPrint39

Proton C, optimized the reading procedure using 'readPort()'.

  • Processing time for Row0: 9.2us

DS1Z_QuickPrint40

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The following macros have been added to gpio.h.

* readPort(port)
* setPortBitInput(port, bit)
* setPortBitInputHigh(port, bit)
* setPortBitOutput(port, bit)
* writePortBitLow(port, bit)
* writePortBitHigh(port, bit)
@github-actions github-actions bot added the core label Apr 30, 2021
@mtei mtei requested a review from a team April 30, 2021 17:54
@drashna drashna requested review from fauxpark, tzarc and zvecr May 9, 2021 03:19
@tzarc tzarc requested review from drashna and a team June 1, 2021 13:50
@mtei mtei merged commit b72f10c into qmk:develop Jun 7, 2021
@mtei mtei deleted the add_readPort_to_gpio.h branch July 8, 2021 19:02
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
* add readPort() and some API to 'tmk_core/common/*/gpio.h'

The following macros have been added to gpio.h.

* readPort(port)
* setPortBitInput(port, bit)
* setPortBitInputHigh(port, bit)
* setPortBitOutput(port, bit)
* writePortBitLow(port, bit)
* writePortBitHigh(port, bit)

* add data type 'port_data_t' into gpio.h

* rename qmk_pin to pin
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
* add readPort() and some API to 'tmk_core/common/*/gpio.h'

The following macros have been added to gpio.h.

* readPort(port)
* setPortBitInput(port, bit)
* setPortBitInputHigh(port, bit)
* setPortBitOutput(port, bit)
* writePortBitLow(port, bit)
* writePortBitHigh(port, bit)

* add data type 'port_data_t' into gpio.h

* rename qmk_pin to pin
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* add readPort() and some API to 'tmk_core/common/*/gpio.h'

The following macros have been added to gpio.h.

* readPort(port)
* setPortBitInput(port, bit)
* setPortBitInputHigh(port, bit)
* setPortBitOutput(port, bit)
* writePortBitLow(port, bit)
* writePortBitHigh(port, bit)

* add data type 'port_data_t' into gpio.h

* rename qmk_pin to pin
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* add readPort() and some API to 'tmk_core/common/*/gpio.h'

The following macros have been added to gpio.h.

* readPort(port)
* setPortBitInput(port, bit)
* setPortBitInputHigh(port, bit)
* setPortBitOutput(port, bit)
* writePortBitLow(port, bit)
* writePortBitHigh(port, bit)

* add data type 'port_data_t' into gpio.h

* rename qmk_pin to pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants