x-bows nature: fix led order and colors #12871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhirev
changed the title
|
@XBowsTech can you confirm this fix, or is it due to a different PCB revision? |
drashna
approved these changes
May 12, 2021
|
Thanks! |
|
The commit b0a7dbd causes my I received my X-Bows Nature yesterday, so I assume it's a pretty recent version. If there are no changes in the PCB, I guess this is not correct. |
|
@x3rAx I confirm this. There's one more place somewhere where numbers need to be fixed… I'll take a look. |
|
I'm sorry, it was my mistake. The strange numbering of LEDs reflects the wiring of keys. That commit should be reverted. |
mikhirev
added a commit
to mikhirev/qmk_firmware
that referenced
this pull request
May 13, 2021
7 tasks
toddyamakawa
pushed a commit
to toddyamakawa/qmk_firmware
that referenced
this pull request
May 19, 2021
nooges
pushed a commit
that referenced
this pull request
May 19, 2021
leland-kwong
pushed a commit
to leland-kwong/qmk_firmware
that referenced
this pull request
May 23, 2021
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for two fixes in X-bows Nature LED matrix:
Types of Changes