-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternate ldscript for STM32duino (F103xB) #12914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of duplication to change just a single value, but I suppose that you want this to look exactly like ChibiOS, where no common parts are factored out in .ld files.
Thank you for your contribution! |
a835d8d
to
f780b77
Compare
I guess it could be done that way. I haven't really looked into how to write ldscripts. |
Never mind, apparently I was missing a semicolon. It seems to work now but it requires adding this to chibios.mk: LDFLAGS += -L$(TOP_DIR)/platforms/chibios/common/ld |
* Add alternate ldscript for STM32duino (F103xB) * Refactor out common ldscript stuff * Move ldscripts into stm32duino board dir, add search path to ldflags
* Add alternate ldscript for STM32duino (F103xB) * Refactor out common ldscript stuff * Move ldscripts into stm32duino board dir, add search path to ldflags
Description
Factored out the common code in the STM32duino ldscript. The search path to find the common ldscript needs to be added to
LDFLAGS
; I have only done this for the case whereMCU_LDSCRIPT
is found in$(TOP_DIR)/platforms/chibios/$(BOARD)
.Types of Changes
Issues Fixed or Closed by This PR
Checklist