Added right vs left specific pin assignments for dip switch

[XScorpion2]

Description

Added right vs left support for dip switch pin configuration

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[mtei]

The following code seems a little hard to read to me.

#ifdef DIP_SWITCH_PINS
#    if defined(SPLIT_KEYBOARD) && defined(DIP_SWITCH_PINS_RIGHT)
        if (isLeftHand) {
#    endif
            dip_switch_state[i] = !readPin(dip_switch_pad[i]);
#    if defined(SPLIT_KEYBOARD) && defined(DIP_SWITCH_PINS_RIGHT)
        } else {
            dip_switch_state[i] = !readPin(dip_switch_pad_right[i]);
        }
#    endif
#endif

I suggest code like 197ea02.

[tzarc]

I've marked this with the breaking_2021q3 label -- if we can get mtei's suggestion sorted I think this can go in.

[zvecr]

While i agree the code could be cleaner, the suggestion in 197ea02 is way worse.

The context of the code is completely lost because the left/right logic bleeds out into code that still sometimes doesn't compile. However now you need to know context from the confusingly named variable names.

I'm going to merge this as is due to the time to develop merge. The interface is fine and we can tidy up the implementation in another iteration.