Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added basic midi documention of common features #13113

Merged
merged 14 commits into from
Jun 7, 2021
Merged

added basic midi documention of common features #13113

merged 14 commits into from
Jun 7, 2021

Conversation

wxyangf
Copy link

@wxyangf wxyangf commented Jun 5, 2021 •
edited
Loading

Description

I've added documentation for all of the MIDI features that I've actually seen used in keymaps.

Additional documentation for lesser used MIDI features may be added in the future.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Notes

Please review spelling and such, I am quite bad at it.

@wxyangf wxyangf force-pushed the midi_doc_improvements branch from 3e2bdbb to fc9c0cd Compare June 5, 2021 05:17
@drashna
Copy link
Member

drashna commented Jun 5, 2021

Just a heads up, you'd need to add a link to _sidebar.md so that it shows up there.

@wxyangf
Copy link
Author

wxyangf commented Jun 5, 2021

Will do in the morning. o7 I'll also rebase this into a single commit.

precondition
precondition reviewed Jun 5, 2021
View reviewed changes
docs/feature_midi.md Outdated Show resolved Hide resolved
@precondition
Copy link
Contributor

You could also consider adding the table of midi keycodes to the keycodes.md file in order to solve #9868 while you're at it.

precondition
precondition reviewed Jun 5, 2021
View reviewed changes
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
@wxyangf @precondition
Fixup spelling issues
e535680 
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
@wxyangf
Copy link
Author

wxyangf commented Jun 5, 2021

Thank you for the spelling fixes, going to fixup the 'process_record_user' description, then make this a real pr.

@wxyangf wxyangf marked this pull request as ready for review June 5, 2021 18:31
fauxpark
fauxpark requested changes Jun 5, 2021
View reviewed changes
docs/_summary.md Outdated Show resolved Hide resolved
docs/feature_audio.md Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
@wxyangf
Made changes as per @fauxpark's review
314212a 
Changes made:

 - Alphabetized _summary.md
 - Removed comment from feature_audio.md
 - Removed extra line from begining of feature_midi.md
 - Removed keycode value col from feature_midi.md

Changes not made and reasoning:

 - Kept link to feature_midi.md in feature_audio.md
 	- Audio and MIDI are linked in the build feature and in
	functionality thus it is appropriate for audio to
	have a link to MIDI
 - Kept refernce and background section
 	- Need references and background for more advanced MIDI feature
	- EG. List and function of various CC codes
	- EG. Various still not documented MIDI features such as
	bi-directional communication
	- Helpful for people starting to work on the MIDI feature
@wxyangf wxyangf requested a review from fauxpark June 5, 2021 20:58
fauxpark
fauxpark requested changes Jun 5, 2021
View reviewed changes
docs/feature_midi.md Outdated Show resolved Hide resolved
wxyangf and others added 2 commits June 5, 2021 17:39
@wxyangf @fauxpark
Add Alias Col
4fbb1c8 
Co-authored-by: Ryan <fauxpark@gmail.com>
@wxyangf
As per @fauxpark's second review
d54f611 
Removed background section

Commented out QMK Internals section, because while it may be useful,
it's autogenerated and thus not of high quality.

Kept list of MIDI c files because they haven't changed and aren't likely
to change, and if they do change, it would be simple enough for me to
update the list, as I plan to make more PRs with more information on the
MIDI system.
fauxpark
fauxpark requested changes Jun 5, 2021
View reviewed changes
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
wxyangf and others added 2 commits June 5, 2021 18:19
fauxpark
fauxpark requested changes Jun 5, 2021
View reviewed changes
docs/feature_midi.md Outdated Show resolved Hide resolved
@wxyangf
Copy link
Author

wxyangf commented Jun 5, 2021

What still needs to be documented in the MIDI system.

  1. all the MIDI_xx_send
  2. Receiving MIDI
  3. Sending raw midi
  4. using analog components (sliders, potentiometers, etc.) with midi
  5. using rotary encoders with midi
  6. and prob a bunch more things that will pop up as documentation happens.

@wxyangf @fauxpark @zvecr
Make codetype for codeblock 'makefile'
6f50416 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
fauxpark
fauxpark requested changes Jun 5, 2021
View reviewed changes
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
docs/feature_midi.md Outdated Show resolved Hide resolved
@wxyangf @fauxpark
@fauxpark Changes for clarification
5168f86 
Co-authored-by: Ryan <fauxpark@gmail.com>
@wxyangf
Copy link
Author

wxyangf commented Jun 5, 2021

Personally I think having the full list of CC codes in the QMK documentation would be overkill.

@wxyangf wxyangf requested a review from fauxpark June 6, 2021 00:42
fauxpark
fauxpark requested changes Jun 6, 2021
View reviewed changes
docs/feature_midi.md Show resolved Hide resolved
@wxyangf @fauxpark
Add midi struct info
fc7526e 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark fauxpark requested a review from a team June 6, 2021 18:35
@drashna drashna merged commit b10728e into qmk:master Jun 7, 2021
@drashna
Copy link
Member

drashna commented Jun 7, 2021

Thanks!!

@wxyangf wxyangf deleted the midi_doc_improvements branch June 7, 2021 07:02
@wxyangf
Copy link
Author

wxyangf commented Jun 7, 2021

IT ONLY TOOK 4 YEARS, BUT THE DOCUMENTATION HAS BEEN STARTED 🎉

spRite75 added a commit to spRite75/qmk_firmware that referenced this pull request Jun 7, 2021
@spRite75 @Erovia
@fauxpark @jackhumbert @drashna @gunpinyo @kevinzhao-tech @eithanshavit @afternoonlabs @stanrc85 @Jonavin @stefanopace @noroadsleft @peepeetee @beansrowning @hexadecatrienoic @rainkeebs @thompson-ele @evyd13 @nopunin10did @Rossman360 @DaneEvans @HellSingCoder @tzarc @sigprof @lukeski14 @blewis308 @stevendlander @ohchiko @lja83 @Xelus22 @jdelkins @bcat @umi-umi @shelaf @mtei @TerryMathews @NathanBlais @msf @HalfHeuslerAlloy @bbrfkr @matthewdias @wxyangf @precondition @zvecr
get latest upstream (#2)
1851dcd 
* Keyboard: Planck THK (qmk#12597)

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jack Humbert <jack.humb@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>

* [Keymap] update gunp layout for Planck (qmk#12926)

Co-authored-by: Ryan <fauxpark@gmail.com>

* [Keyboard] SKErgo (qmk#12923)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* [Keyboard] Adjustments to Gust Rev1.2 (qmk#12716)

Co-authored-by: Eithan Shavit <eithan@afternoonlabs.com>

* [Keyboard] Add RGB Matrix support for Bear65 PCB (qmk#12961)

Co-authored-by: Drashna Jaelre <drashna@live.com>

* [Keymap] Add mercutio keymap and update readme.md for layouts (qmk#12973)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jonavin <=>

* [Keymap] Add new keymap for ut472 (qmk#12974)

* [Keyboard] Removed LAYOUTS = ortho_6x16 (qmk#12983)

Removed ortho_6x16 community layout support by commenting out the line.

This can be reversed if that layout ever gets added.

* Document RGB_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12984)

* [Keyboard] Fix Clawsome/Sedan matrix and default keymap (qmk#13007)

* Add keymap with scrolling mode for the Ploopy Nano trackball (qmk#13013)

Co-authored-by: Drashna Jaelre <drashna@live.com>

* [Keyboard] Fix Delilah VIA Keymap (qmk#13008)

Co-authored-by: Drashna Jaelre <drashna@live.com>

* [Keyboard] Add F.Me Macropad (qmk#12658)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* [Keyboard] Add VIA to Aves65 (qmk#12990)

* [Keyboard] Add Jabberwocky Keyboard (qmk#12500)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Rossman360 <rmontsinger@gmail.com>

* [Keyboard] Corgi keyboard (qmk#12311)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* [Keymap] add personal keymap files, and sofle_rgb default maps, (qmk#12267)

* Sofle rev1 Keymap - featuring keyboard pets (qmk#12499)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* CLI/c2json: Print 'cpp' error when executed in verbose mode (qmk#12869)

Co-authored-by: Ryan <fauxpark@gmail.com>

* World domination (qmk#13021)

Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Ryan <fauxpark@gmail.com>

* 2021 May 29 Breaking Changes Update (qmk#13034)

* Add Per Key functionality for AutoShift (qmk#11536)

* LED Matrix: Reactive effect buffers & advanced indicators (qmk#12588)

* [Keyboard] kint36: switch to sym_eager_pk debouncing (qmk#12626)

* [Keyboard] kint2pp: reduce input latency by ≈10ms (qmk#12625)

* LED Matrix: Split (qmk#12633)

* [CI] Format code according to conventions (qmk#12650)

* feat: infinite timeout for leader key (qmk#6580)

* feat: implement leader_no_timeout logic

* docs(leader_key): infinite leader timeout docs

* Format code according to conventions (qmk#12680)

* Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (qmk#12403)

* Fix default ADC_RESOLUTION for ADCv3 (and ADCv4)

Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers
(that macro should not have been there, because ADCv3 has CFGR instead of
CFGR1).  Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS
if it is defined (that name is used for ADCv3 and ADCv4).

* Update ADC docs to match the actually used resolution

ADC driver for ChibiOS actually uses the 10-bit resolution by default
(probably to match AVR); fix the documentation accordingly.  Also add
both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names
differ according to the ADC implementation in the particular MCU).

* Fix pinToMux() for B12 and B13 on STM32F3xx

Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and
B13 pins were wrong.

* Add support for all possible analog pins on STM32F1xx

Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx
(they are the same at least for STM32F103x8 and larger F103 devices, and
also F102, F105, F107 families).  Actually tested on STM32F103C8T6
(therefore pins C0...C5 were not tested).

Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages,
cannot be supported at the moment, because those pins are connected only
to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1.

* Add support for all possible analog pins on STM32F4xx

Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally
F3...F10 (if STM32_ADC_USE_ADC3 is enabled).  These mux values are
apparently the same for all F4xx devices, except some smaller devices may
not have ADC3.

Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using
various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested.

Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices
which don't have ADC3 also don't have the GPIOF port, therefore the code
which refers to Fx pins does not compile.

* Fix STM32F3xx ADC mux table in documentation

The ADC driver documentation had some errors in the mux table for STM32F3xx.
Fix this table to match the datasheet and the actual code (mux settings for
B12 and B13 were also tested on a real STM32F303CCT6 chip).

* Add STM32F1xx ADC pins to the documentation

* Add STM32F4xx ADC pins to the documentation

* Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (qmk#12600)

* Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example.

* Update flashing.md

* Update chconf.h

* Update config.h

* Update halconf.h

* Update mcuconf.h

* eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (qmk#12671)

* Add support for MCU = STM32F446 (qmk#12619)

* Add support for MCU = STM32F446

* Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h

* Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64

* stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled.

* Format code according to conventions (qmk#12682)

* Format code according to conventions (qmk#12687)

* Add STM32L433 and L443 support (qmk#12063)

* initial L433 commit

* change to XC

* fix L433

* disable all peripherals

* update system and peripheral clocks

* 433 change

* use its own board  files

* revert its own board files

* l433 specific change

* fix stm32l432xx define

* remove duplicate #define

* fix bootloader jump

* move to L443xx and add i2c2, spi2, usart3 to mcuconf.h

* move to L443

* move to L443

* fix sdmmc in mcuconf.h

* include STM32L443

* add L443

* Include L443 in compatible microcontrollers

* Include L443 in compatible microcontrollers

* Update config bootloader jump description

* Update ChibiOS define reasoning

* Update quantum/mcu_selection.mk

* fix git conflict

* Updated Function96 with V2 files and removed chconf.h and halconf.h (qmk#12613)

* Fix bad PR merge for qmk#6580. (qmk#12721)

* Change RGB/LED Matrix to use a simple define for USB suspend (qmk#12697)

* [CI] Format code according to conventions (qmk#12731)

* Fixing transport's led/rgb matrix suspend state logic (qmk#12770)

* [CI] Format code according to conventions (qmk#12772)

* Fix comment parsing (qmk#12750)

* Added OLED fade out support (qmk#12086)

* fix some references to bin/qmk that slipped in (qmk#12832)

* Resolve a number of warnings in `qmk generate-api` (qmk#12833)

* New command: qmk console (qmk#12828)

* stash poc

* stash

* tidy up implementation

* Tidy up slightly for review

* Tidy up slightly for review

* Bodge environment to make tests pass

* Refactor away from asyncio due to windows issues

* Filter devices

* align vid/pid printing

* Add hidapi to the installers

* start preparing for multiple hid_listeners

* udev rules for hid_listen

* refactor to move closer to end state

* very basic implementation of the threaded model

* refactor how vid/pid/index are supplied and parsed

* windows improvements

* read the report directly when usage page isn't available

* add per-device colors, the choice to show names or numbers, and refactor

* add timestamps

* Add support for showing bootloaders

* tweak the color for bootloaders

* Align bootloader disconnect with connect color

* add support for showing all bootloaders

* fix the pyusb check

* tweaks

* fix exception

* hide a stack trace behind -v

* add --no-bootloaders option

* add documentation for qmk console

* Apply suggestions from code review

* pyformat

* clean up and flesh out KNOWN_BOOTLOADERS

* Remove pointless SERIAL_LINK_ENABLE rules (qmk#12846)

* Make Swap Hands use PROGMEM (qmk#12284)

This converts the array that the Swap Hands feature uses to use PROGMEM,
and to read from that array, as such. Since this array never changes at
runtime, there is no reason to keep it in memory. Especially for AVR
boards, as memory is a precious resource.

* Fix another bin/qmk reference (qmk#12856)

* [Keymap] Turn OLED off on suspend in soundmonster keymap (qmk#10419)

* Fixup build errors on `develop` branch. (qmk#12723)

* LED Matrix: Effects! (qmk#12651)

* Fix syntax error when compiling for ARM (qmk#12866)

* Remove KEYMAP and LAYOUT_kc (qmk#12160)

* alias KEYMAP to LAYOUT

* remove KEYMAP and LAYOUT_kc

* Add setup, clone, and env to the list of commands we allow even with broken modules (qmk#12868)

* Rename `point_t` -> `led_point_t` (qmk#12864)

* [Keyboard] updated a vendor name / fixed minor keymap issues (qmk#12881)

* Add missing LED Matrix suspend code to suspend.c (qmk#12878)

* LED Matrix: Documentation (qmk#12685)

* Deprecate `send_unicode_hex_string()` (qmk#12602)

* Fix spelling mistake regarding LED Matrix in split_common. (qmk#12888)

* [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (qmk#12895)

* Use milc.subcommand.config instead of qmk.cli.config (qmk#12915)

* Use milc.subcommand.config instead

* pyformat

* remove the config test

* Add function to allow repeated blinking of one layer (qmk#12237)

* Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time

* Update doc

* Rework rgblight blinking according to requested change

* optimize storage

* Fixup housekeeping from being invoked twice per loop. (qmk#12933)

* matrix: wait for row signal to go HIGH for every row (qmk#12945)

I noticed this discrepancy (last row of the matrix treated differently than the
others) when optimizing the input latency of my keyboard controller, see also
https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/

Before this commit, when tuning the delays I noticed ghost key presses when
pressing the F2 key, which is on the last row of the keyboard matrix: the
dead_grave key, which is on the first row of the keyboard matrix, would be
incorrectly detected as pressed.

After this commit, all keyboard matrix rows are interpreted correctly.

I suspect that my setup is more susceptible to this nuance than others because I
use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask
the problem.

* ensure we do not conflict with existing keymap aliases (qmk#12976)

* Add support for up to 4 IS31FL3733 drivers (qmk#12342)

* Convert Encoder callbacks to be boolean functions (qmk#12805)

* [Keyboard] Fix Terrazzo build failure (qmk#12977)

* Do not hard set config in CPTC files (qmk#11864)

* [Keyboard] Corne - Remove legacy revision support (qmk#12226)

* [Keymap] Update to Drashna keymap and user code (based on develop) (qmk#12936)

* Add Full-duplex serial driver for ARM boards (qmk#9842)

* Document LED_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12987)

* Backlight: add defines for default level and breathing state (qmk#12560)

* Add dire message about LUFA mass storage bootloader (qmk#13014)

* [Keyboard] Remove redundant legacy and common headers for crkbd (qmk#13023)

Was causing compiler errors on some systems.

* Fix keyboards/keymaps for boolean encoder callback changes (qmk#12985)

* `backlight.c`: include `eeprom.h` (qmk#13024)

* Add changelog for 2021-05-29 Breaking Changes merge (qmk#12939)

* Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version

* Add recent develop changes

* Sort recent develop changes

* Remove sections for ChibiOS changes per tzarc

No ChibiOS changes this round.

* Add and sort recent develop changes

* add notes about keyboard moves/deletions

* import changelog for PR 12172

Documents the change to BOOTMAGIC_ENABLE.

* update section headings

* re-sort changelog

* add additional note regarding Bootmagic changes

* remove changelog timestamp

* update dates in main Breaking Changes docs

* fix broken section anchors in previous changelogs

* add link to backlight/eeprom patch to changelog

* highlight some more changes

* link PRs from section headers

* Restore standard readme

* run: qmk cformat --core-only

* CLI: Fix automagic (qmk#13046)

* merge/um70:via: Avoid sprintf() to make the code fit into flash (qmk#12919)

The code using sprintf() did not fit into flash when `merge/um70:via`
was compiled with avr-gcc 5.4.0:

     * The firmware is too large! 29756/28672 (1084 bytes over)

Replacing `sprintf(wpm_str, " %03d", current_wpm);` with custom
formatting code reduces the firmware size by 1504 bytes, which is enough
to make the `merge/um70:via` firmware fit:

    * The firmware size is approaching the maximum - 28252/28672 (98%, 420 bytes free)

* [Keyboard] jabberwocky via support (qmk#13029)

* [Keyboard] Added BOP support (qmk#12991)

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Brandon Lewis <blewis308@users.noreply.github.com>

* [Keyboard] Unicomp Mini M (qmk#12892)

* [Keyboard] Add Rubi Numpad (qmk#12283)

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* [Keymap] lja83's Planck keymap (qmk#12809)

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Jeff Apczynski <jeffrey.apczynski@braincorp.com>

* VIA compile fixes (qmk#13054)

* fix missing arg (qmk#13068)

* [Keymap] merge jdelkins userspace and associated keymaps (qmk#11276)

* [Keymap] merge jdelkins userspace and associated keymaps

* Add copyright & license info

* Change rgblight_config.enable to rgblight_is_enabled()

* Update keyboards/dz60/keymaps/jdelkins/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Update keyboards/dz60/keymaps/jdelkins/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Update keyboards/dz60/keymaps/jdelkins/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Remove superfluous includes

* Change EXTRAFLAGS+=-flto to LTO_ENABLE=yes

* Remove unnecessary jdelkins_ss symlink in users

* Add copyright and license notices

* Use preferred way to determine capslock / numlock state

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add #pragma once to a header

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Include QMK_KEYBOARD_H only once, in userspace header

* Remove unnecessary initialization in matrix_init_keymap

* Do process_record_keymap before cases handled in process_record_user

* Reorganize & simplify secrets feature enablement

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove superfluous break

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove copyright from rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove copyright from rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* include "print.h" instead of <print.h>

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_cod16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove copyright from rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* add #pragma once to a header

Co-authored-by: Ryan <fauxpark@gmail.com>

* include "print.h" instead of <print.h>

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove copyright from rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove copyright from rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove copyright from rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use tap_code16

Co-authored-by: Ryan <fauxpark@gmail.com>

* Use :flash target where possible

* Remove special case flash target and use PROGRAM_CMD

* dz60/jdelkins_ss: use tap_code16

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Fix up WS2812 SPI driver on F072. (qmk#13022)

* Update noroadsleft userspace and keymaps (2021-06-02) (qmk#13086)

* Tidy up spi_master includes (qmk#13053)

* `qmk multibuild`: Fix bug with Path objects (qmk#13093)

* [Keymap] Update bcat's split_3x6_3 for Crkbd legacy removal (qmk#13097)

* Fix caps lock indicator on Bear65 PCB (qmk#12966)

* kbdfans/kbd67/rev2: add LAYOUT_65_ansi_split_space layout data (qmk#13102)

* Fix includes for pmw3360 driver (qmk#13108)

* update feature_layers.md translation (qmk#12752)

* Update Japanese document (qmk#10670)

Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

* JETVAN: Add initial support (qmk#12790)

Co-authored-by: Ryan <fauxpark@gmail.com>

* Corrected Number-pad numbers (qmk#13057)

* [Keymap] add id80/ansi/keymaps/msf (qmk#11957)

* Fixed ISO keyboard layout for the Mysterium rev1.1 board (qmk#12531)

* [Keyboard] add molecule (qmk#12601)

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>

* [Keyboard] Add program yoink via keymap (qmk#12645)

Co-authored-by: Ryan <fauxpark@gmail.com>

* [Docs] added basic midi documention of common features (qmk#13113)

Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>

* Add default `ortho_1x1` layout (qmk#13118)

Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Jack Humbert <jack.humb@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Gun Pinyo <gunpinyo@gmail.com>
Co-authored-by: C1intMason <zhao1939@gmail.com>
Co-authored-by: Eithan Shavit <eithanshavit@users.noreply.github.com>
Co-authored-by: Eithan Shavit <eithan@afternoonlabs.com>
Co-authored-by: stanrc85 <47038504+stanrc85@users.noreply.github.com>
Co-authored-by: Jonavin <71780717+Jonavin@users.noreply.github.com>
Co-authored-by: Stefano Pace <s.pace1@studenti.unimol.it>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: peepeetee <43021794+peepeetee@users.noreply.github.com>
Co-authored-by: Sean Browning <25888380+beansrowning@users.noreply.github.com>
Co-authored-by: Maddie O'Brien <hexadecatrienoic@users.noreply.github.com>
Co-authored-by: rainkeebs <44819800+rainkeebs@users.noreply.github.com>
Co-authored-by: thompson-ele <ele.thompson12@gmail.com>
Co-authored-by: Evelien-Lillian Dekkers <sixmoonskies@gmail.com>
Co-authored-by: nopunin10did <w.alex.ronke@gmail.com>
Co-authored-by: Rossman360 <rmontsinger@gmail.com>
Co-authored-by: Christian Sandven <christian.sandven@kindly.ai>
Co-authored-by: DaneEvans <dane@goneepic.com>
Co-authored-by: CodeFreak <lisca94@gmail.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: lukeski14 <73951271+lukeski14@users.noreply.github.com>
Co-authored-by: Brandon Lewis <64657834+blewis308@users.noreply.github.com>
Co-authored-by: Brandon Lewis <blewis308@users.noreply.github.com>
Co-authored-by: Lander <3169732+stevendlander@users.noreply.github.com>
Co-authored-by: Gregorio <38576492+ohchiko@users.noreply.github.com>
Co-authored-by: Jeff Apczynski <jeff.apczynski@gmail.com>
Co-authored-by: Jeff Apczynski <jeffrey.apczynski@braincorp.com>
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
Co-authored-by: Joel Elkins <joel@elkins.co>
Co-authored-by: Jonathan Rascher <jon@bcat.name>
Co-authored-by: umi <57262844+umi-umi@users.noreply.github.com>
Co-authored-by: shela <shelaf@users.noreply.github.com>
Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>
Co-authored-by: TerryMathews <terry@terrymathews.net>
Co-authored-by: Nathan_Blais <37645161+NathanBlais@users.noreply.github.com>
Co-authored-by: Miguel Filipe <msf@users.noreply.github.com>
Co-authored-by: HalfHeuslerAlloy <49373316+HalfHeuslerAlloy@users.noreply.github.com>
Co-authored-by: bbrfkr <bbrfkr@gmail.com>
Co-authored-by: Matthew Dias <matthewdias@me.com>
Co-authored-by: wxyangf <2058629+wxyangf@users.noreply.github.com>
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
Co-authored-by: Joel Challis <git@zvecr.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@wxyangf @precondition
@fauxpark @zvecr @HokieGeek
[Docs] added basic midi documention of common features (qmk#13113)
1692e55 
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@wxyangf @precondition
@fauxpark @zvecr @wox
[Docs] added basic midi documention of common features (qmk#13113)
a9550d0 
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@wxyangf @precondition
@fauxpark @zvecr @nhongooi
[Docs] added basic midi documention of common features (qmk#13113)
6fb20e1 
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@wxyangf @precondition
@fauxpark @zvecr
[Docs] added basic midi documention of common features (qmk#13113)
c793c77 
Co-authored-by: precondition <57645186+precondition@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@precondition precondition precondition left review comments

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wxyangf @drashna @precondition @fauxpark @zvecr