Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbdfans and dztech cleanup #13179

Closed
wants to merge 9 commits into from
Closed

Conversation

kb-elmo
Copy link
Contributor

@kb-elmo kb-elmo commented Jun 11, 2021

Description

Big cleanup of all newer KBDfans and DZtech keyboards/PCBs (I didn't really touch the old ones that aren't manufactured/sold anymore).

Changes:

  • Cleaned up the config files
  • Cleaned up the default/via keymaps and changed some of them to be a bit more "standard"
  • Re-enabled most RGB animations on the RGB PCBs since there is no need to disable them. The boards have plenty of flash for those. I kept some of the more redundant looking ones disabled on the request of KBDfans.
  • Removed the USB startup check on all boards that had it set. This is known to cause issues with the board not starting up after rebooting the computer
  • Changed the debounce on all PCBs back to the default 5ms. People have been reporting chattering issues on some boards where it was set to 3ms
  • Moved the DZ60 into the DZtech directory with all his other PCBs
  • Changed the directory structure for the KBDfans Maja to match the other KBDfans boards

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 11, 2021
@zvecr zvecr changed the base branch from master to develop June 11, 2021 16:49
@kb-elmo
Copy link
Contributor Author

kb-elmo commented Jul 27, 2021

updated the branch

keyboards/dztech/dz60rgb_ansi/v1/config.h Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb/v2_1/config.h Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb/v2/config.h Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb/v1/config.h Outdated Show resolved Hide resolved
keyboards/dztech/dz60rgb_ansi/v2/config.h Outdated Show resolved Hide resolved
keyboards/dztech/dz65rgb/v2/config.h Outdated Show resolved Hide resolved
keyboards/kbdfans/bella/rgb/config.h Outdated Show resolved Hide resolved
keyboards/kbdfans/bella/rgb_iso/config.h Outdated Show resolved Hide resolved
keyboards/kbdfans/kbd67/mkiirgb/v2/config.h Outdated Show resolved Hide resolved
keyboards/kbdfans/maja/hotswap/config.h Outdated Show resolved Hide resolved
Co-authored-by: Drashna Jaelre <drashna@live.com>
@stale
Copy link

stale bot commented Sep 14, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna
Copy link
Member

drashna commented Sep 15, 2021

This has a bunch of merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants