Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix-shell update poetry and add hidapi #13227

Closed

Conversation

rgoulter
Copy link
Contributor

Fix shell.nix.

Description

#12828 added hidapi and pyusb to the Python requirements.

shell.nix is used by Nix/NixOS's nix-shell. With the current implementation, it relies on poetry for handling Python dependencies rather than the requirements.txt. i.e. shell.nix should to be updated after requirements.txt is updated.

The files under nix/ were updated by using the commands documented in shell.nix.

The hidapi Python package also requires the native library hidapi to be available. It's added to the LD_LIBRARY_PATH in the shell hook.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member

Looks like duplicate of #12855

@rgoulter
Copy link
Contributor Author

Ah, hadn't seen that PR. Thanks.

@rgoulter rgoulter closed this Jun 17, 2021
@rgoulter rgoulter deleted the nix-shell-update-poetry-and-add-hidapi branch November 4, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants