Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Switchplate 910 keyboard #13235

Merged
merged 8 commits into from
Jun 19, 2021
Merged

Add Switchplate 910 keyboard #13235

merged 8 commits into from
Jun 19, 2021

Conversation

MxBlu
Copy link
Contributor

@MxBlu MxBlu commented Jun 18, 2021 •
edited
Loading

Description

Adding Switchplate 910 keyboard on behalf of Stefan Karsh (hence the license headers)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 18, 2021
fauxpark
fauxpark requested changes Jun 18, 2021
View reviewed changes
keyboards/switchplate/switchplate910/config.h Outdated Show resolved Hide resolved
keyboards/switchplate/switchplate910/rules.mk Outdated Show resolved Hide resolved
keyboards/switchplate/switchplate910/rules.mk Outdated Show resolved Hide resolved
keyboards/switchplate/switchplate910/switchplate910.c Outdated Show resolved Hide resolved
keyboards/switchplate/switchplate910/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/switchplate/switchplate910/switchplate910.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team June 18, 2021 12:24
@MxBlu
Copy link
Contributor Author

MxBlu commented Jun 18, 2021

Faster than I was reading through the PR checklist, done

MxBlu and others added 3 commits June 18, 2021 22:40
@MxBlu @fauxpark
Re-add "bootloader selection" comment to rules.mk
40d097f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@MxBlu @fauxpark
Re-add BLUETOOTH_ENABLE to rules.mk
52aa5a8 
Co-authored-by: Ryan <fauxpark@gmail.com>
@MxBlu
Remove whitespace
8d3ec74
@drashna
Copy link
Member

drashna commented Jun 19, 2021

Thanks!

@drashna drashna merged commit dfcefc2 into qmk:master Jun 19, 2021
@MxBlu MxBlu mentioned this pull request Jun 21, 2021
Merged
6 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@MxBlu @fauxpark @HokieGeek
[Keyboard] Add Switchplate 910 keyboard (qmk#13235)
331e8c2 
Co-authored-by: Ryan <fauxpark@gmail.com>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@MxBlu @fauxpark @wox
[Keyboard] Add Switchplate 910 keyboard (qmk#13235)
6ed8114 
Co-authored-by: Ryan <fauxpark@gmail.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@MxBlu @fauxpark @nhongooi
[Keyboard] Add Switchplate 910 keyboard (qmk#13235)
62ea547 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MxBlu @drashna @fauxpark