Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bm60rgb: fix layout macro references #13246

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

noroadsleft
Copy link
Member

Description

  • fixes broken layout macro reference in info.json
  • enables Community Layout support

Edits the default and via keymaps to use the corrected layout macro reference, but no edits to the jbradforddillon keymap so as to keep this out of Breaking Changes.

Issue reported by matthijsboog#5156 on QMK Discord.

Types of Changes

  • Bugfix
  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

... and enable Community Layout support
@noroadsleft noroadsleft added bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 19, 2021
@noroadsleft noroadsleft requested a review from a team June 19, 2021 07:58
@fauxpark fauxpark requested a review from a team June 19, 2021 08:41
@Erovia Erovia merged commit 939ce6a into qmk:master Jun 19, 2021
@noroadsleft noroadsleft deleted the cf/bm60rgb branch June 19, 2021 15:58
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
... and enable Community Layout support
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
... and enable Community Layout support
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
... and enable Community Layout support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants