Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow LINE_PINxx for Teensy 4.x pins #13247

Merged
merged 1 commit into from
Jun 19, 2021
Merged

allow LINE_PINxx for Teensy 4.x pins #13247

merged 1 commit into from
Jun 19, 2021

Conversation

stapelberg
Copy link
Contributor

Description

As discussed in #13052, we should use LINE_PINxx on Teensy 4.x. This PR makes that possible.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jun 19, 2021
This was referenced Jun 19, 2021
Closed
Closed
@tzarc tzarc requested review from skullydazed and a team June 19, 2021 11:35
@skullydazed skullydazed merged commit 7c5ef40 into qmk:develop Jun 19, 2021
@stapelberg stapelberg mentioned this pull request Jun 20, 2021
Closed
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@stapelberg @nhongooi
allow LINE_PINxx for Teensy 4.x pins (qmk#13247)
beea9d7 
fixes qmk#13052
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@stapelberg
allow LINE_PINxx for Teensy 4.x pins (qmk#13247)
b3350c4 
fixes qmk#13052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stapelberg @tzarc @skullydazed