Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LED/RGB Matrix code into their own directories #13257

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

fauxpark
Copy link
Member

Description

No functional changes. quantum/ is getting a bit crowded, and sort of a dumping ground for feature code.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 20, 2021 02:42
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fauxpark
Copy link
Member Author

As a sidenote, the terms "effect" and "animation" are used interchangeably here, but we should probably settle on one or the other for consistency...

@drashna drashna requested a review from a team June 21, 2021 16:41
@fauxpark fauxpark force-pushed the led-rgb-matrix-reorg branch from 7f3e83f to 9f387f7 Compare June 22, 2021 04:40
@fauxpark fauxpark merged commit d61e5c0 into qmk:develop Jun 22, 2021
@fauxpark fauxpark deleted the led-rgb-matrix-reorg branch June 22, 2021 08:26
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants