Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sync of OLED/ST7565 display on/off state on Splits #13542

Merged
merged 2 commits into from
Aug 15, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 14, 2021

Description

This allows the OLED/ST7565 display on/off state to be synced between the halves.

Requires a define to enable.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

quantum/split_common/transactions.c Outdated Show resolved Hide resolved
quantum/split_common/transactions.c Outdated Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Aug 15, 2021

Need to make sure these are sent only when the current state mismatches the previous state.

Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc tzarc merged commit 488aaa0 into qmk:develop Aug 15, 2021
@drashna drashna deleted the feature/display_sync branch August 15, 2021 05:40
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Enable sync of OLED/ST7565 display on/off state on Splits

* Only send if states are not matched

Co-authored-by: Nick Brassel <nick@tzarc.org>

Co-authored-by: Nick Brassel <nick@tzarc.org>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Enable sync of OLED/ST7565 display on/off state on Splits

* Only send if states are not matched

Co-authored-by: Nick Brassel <nick@tzarc.org>

Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants