Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SENDSTRING_BELL code to send_string.h #13566

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Move SENDSTRING_BELL code to send_string.h #13566

merged 1 commit into from
Jul 16, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 16, 2021 •
edited
Loading

Description

I forgot to do this when I moved all the sendstring stuff out of quantum.h. Also allowed for the bell song to be overridden.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 16, 2021 16:08
@drashna drashna merged commit 332a5aa into qmk:develop Jul 16, 2021
@fauxpark fauxpark deleted the sendstring-bell-move branch July 16, 2021 16:41
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Move SENDSTRING_BELL code to send_string.h (qmk#13566)
e327424
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Move SENDSTRING_BELL code to send_string.h (qmk#13566)
6d952a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @ridingqwerty