Split GMMK Pro PCBs into separate revisions, fix RGB mapping on ISO

[Gigahawk]

Description

RGB mapping is unique between ISO and ANSI GMMK Pro PCBs, split each version into a separate revision for proper support.

@Hatbuster @Giesd @tipok I don't actually have an ISO model to test, on so if you could please confirm this actually works.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

• Fixes [Feature Request] GMMK Pro ISO support #13524

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[Gigahawk]

☒ Missing keyboards/gmmk/pro/ansi/readme.md
☒ Lint check failed!
linting gmmk/pro/iso
☒ Missing keyboards/gmmk/pro/iso/readme.md
☒ Lint check failed!

Are individual readmes actually needed for each folder?

[zvecr]

You will want to sort out the keymaps and info.json, as the "common" folder approach wont work as the layout macros are not common. It should look something like....

keyboards/gmmk/pro/ansi/info.json
keyboards/gmmk/pro/ansi/keymaps/default/keymap.c
keyboards/gmmk/pro/iso/info.json
keyboards/gmmk/pro/iso/keymaps/default/keymap.c

[Hatbuster]

@Gigahawk I have pulled your branch onto my local repository (god, I'm bad at git) and switched my keyboard to gmmk/pro/iso instead of gmmk/pro. Built it and flashed it.

On my end the LEDs light up now. Seem to be at least roughly in the right position, too, from what I can tell.
Great stuff, thanks for putting this together!

Can't wait for it to be merged into develop after some cleanup :)

[ForsakenRei]

Just updated to the latest commit. It seems the sideglow LED number changed?
Used my previous ANSI keymap.c and my sideglow color goes to some other keys...

[Gigahawk]

Just updated to the latest commit. It seems the sideglow LED number changed?
Used my previous ANSI keymap.c and my sideglow color goes to some other keys...

Taken from https://github.com/qmk/qmk_firmware/blob/521e24a1b99857ccf8c82782c6b40cb3599aef0f/keyboards/gmmk/pro/pro.c and https://github.com/qmk/qmk_firmware/blob/7a7fe4c16cb3220a724d7ca25409826025ec88ab/keyboards/gmmk/pro/ansi/ansi.c

 $ diff -w ansi.c pro.c
 1c1
 < /* Copyright 2021 Gigahawk
 ---
 > /* Copyright 2021 Glorious, LLC <salman@pcgamingrace.com>
 16,17c16
 <
 < #include "ansi.h"
 ---
 > #include "pro.h"
 20d18
 < // clang-format off
 240d237
 < // clang-format on

[ForsakenRei]

Just updated to the latest commit. It seems the sideglow LED number changed?
Used my previous ANSI keymap.c and my sideglow color goes to some other keys...

Taken from https://github.com/qmk/qmk_firmware/blob/521e24a1b99857ccf8c82782c6b40cb3599aef0f/keyboards/gmmk/pro/pro.c and https://github.com/qmk/qmk_firmware/blob/7a7fe4c16cb3220a724d7ca25409826025ec88ab/keyboards/gmmk/pro/ansi/ansi.c

 $ diff -w ansi.c pro.c
 1c1
 < /* Copyright 2021 Gigahawk
 ---
 > /* Copyright 2021 Glorious, LLC <salman@pcgamingrace.com>
 16,17c16
 <
 < #include "ansi.h"
 ---
 > #include "pro.h"
 20d18
 < // clang-format off
 240d237
 < // clang-format on

Thanks. I found the under glow LED nubmers are now from 66-92 with some keycode mixed in it instead of purely 82-97. I will make some changes to my own keymap.

[Gigahawk]

You must have been using the Glorious mapping, which was ordered by the keyswitch matrix and then the underglow LEDs slapped on at the end.

The merged mapping on develop follows the order of the actual RGB matrix as defined in this comment with column major axis, following the memory layout of the actual RGB driver chips.

[ForsakenRei]

Ah make sense. It's not that hard to change those numbers in keymap either.
Thanks for the help!