Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Develop - void DIP switch usage #13598

Closed
wants to merge 1 commit into from
Closed

[Bug] Develop - void DIP switch usage #13598

wants to merge 1 commit into from

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Jul 19, 2021

Description

Change void to bool usage

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Change void to bool usage

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 changed the base branch from master to develop July 19, 2021 12:57
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jul 19, 2021
@fauxpark fauxpark requested a review from a team July 19, 2021 14:56
@drashna
Copy link
Member

drashna commented Jul 19, 2021

Duplicate of #13404

@drashna drashna marked this as a duplicate of #13404 Jul 19, 2021
@Xelus22
Copy link
Contributor Author

Xelus22 commented Jul 20, 2021

ah sheesh. didn't see that time to close

@Xelus22 Xelus22 closed this Jul 20, 2021
@Xelus22 Xelus22 deleted the develop_via_fixes branch November 13, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @drashna @fauxpark