Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix compile size for the Vitamins Included via keymap #13696

Merged
merged 1 commit into from
Jul 25, 2021
Merged

[Keyboard] Fix compile size for the Vitamins Included via keymap #13696

merged 1 commit into from
Jul 25, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 24, 2021

Description

Disables music mode on via keymap, and a bit of cleaup

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from Duckle29 and a team July 24, 2021 20:49
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 24, 2021
@drashna drashna force-pushed the fix/keyboard_vitamins branch from f58873a to bc6ff72 Compare July 24, 2021 20:55
@fauxpark fauxpark merged commit a030950 into qmk:develop Jul 25, 2021
@drashna drashna deleted the fix/keyboard_vitamins branch July 25, 2021 04:20
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
[Keyboard] Fix compile size for the Vitamins Included via keymap (qmk…
a53c8c5 
…#13696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@Duckle29 Duckle29 Awaiting requested review from Duckle29

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @fauxpark