fix short circuit in led_update_bk #13752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint is complaining about Missing readme.md but one already exists at keyboards/keebio/quefrency/readme.md |
fauxpark
approved these changes
Jul 28, 2021
Yes, this check is not very smart, you can ignore it. |
drashna
approved these changes
Jul 28, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
…#13752) Co-authored-by: Jonavin <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a short circuit evaluation issue in quefrency/rev3/rev3.c that causes the user function led_update_user() to never run when the right side of the board is connected.
Types of Changes
Issues Fixed or Closed by This PR
Checklist