Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] [ChibiOS] Fix alignment of USB out report buffer 2 -> 4 #13838

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

elfmimi
Copy link
Contributor

@elfmimi elfmimi commented Aug 1, 2021

Description

Contents of HID_SET_REPORT requests which set status LEDs' state were not properly being copied.
It could be that this malfunction is only observed when using NUMICRO, Nuvoton NUC123, port of ChibiOS.
Adjusting the alignment restriction fix the issue. Naturally, it should do no harm for other builds.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 1, 2021
@drashna drashna requested a review from a team August 1, 2021 15:12
@mtei mtei requested review from tzarc and zvecr August 1, 2021 15:12
@tzarc tzarc added the bug label Aug 1, 2021
@tzarc tzarc requested a review from a team August 1, 2021 23:30
@zvecr zvecr merged commit 26b62f7 into qmk:develop Aug 1, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants