Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Switch Draculad to using WPM char hack #13886

Merged
merged 1 commit into from
Aug 4, 2021
Merged

[Keyboard] Switch Draculad to using WPM char hack #13886

merged 1 commit into from
Aug 4, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 4, 2021

Description

It's compiling over size. This removes the use of sprintf, and reduces the compiled size.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

  • CI

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the bug label Aug 4, 2021
@drashna drashna requested a review from a team August 4, 2021 18:24
@github-actions github-actions bot added the keymap label Aug 4, 2021
@drashna drashna merged commit 3568eaf into qmk:develop Aug 4, 2021
@drashna drashna deleted the keyboard/fix_draculad branch August 4, 2021 18:30
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
[Keyboard] Switch Draculad to using WPM char hack (qmk#13886)
3154117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @fauxpark