-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keymap] Add andrebrait layout for GMMK Pro #13932
Conversation
Hi @andrebrait, I'm new to QMK and the GMMK Pro and trying my own custom keymap.c. Learning from what you've done here. (My messy keymap is not quite right : https://paste.ofcode.org/4vYCedvzfpKBcN4qKBuSb4 ) Can you tell me what each line does in the following snippet (I understand IFDEF checks to make sure RGB_MATRIX_ENABLE is yes in rules.mk:
If the RGB is NOT enabled you have : Aren't these two functions the same as: rgb_matrix_enable() alone? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
case RGB_VAI: | ||
case RGB_VAD: | ||
case RGB_SPI: | ||
case RGB_SPD: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
keyboards/gmmk/pro/pro.c
Outdated
@@ -14,3 +14,15 @@ | |||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
*/ | |||
#include "pro.h" | |||
|
|||
#ifdef RGB_MATRIX_ENABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drashna without this the GMMK Pro wouldn't wake up from a USB suspend. I guess this now counts as a bugfix 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With it, it's somewhat random whether or not it will wake, but I won't spend too much time on this. I can revert this bit if you think it's better to leave this out.
My bad for the apparent mess and number of commits. I was refining the logic yesterday and I just finished it. Now I don't control writes to the EEPROM manually. Using flags to control state is quite clean, in the end. |
@stickandgum 5ms because I had a couple double leys with 2ms and with the new debouncing algorithm I figured I would have low latency even when pressing keys like crazy, but I have a proposal for making debounce changeable during execution that hasn't received comments yet. As for waking up, currently any key works for me. I guess it's more of a computer firmware thing than an OS thing (though I think you can use the OS to configure that on the computer's firmware level). |
5f3f4dc
to
ab9b75c
Compare
Thanks! |
Description
Just my own layout with an implementation for the CAPS LOCK indicator that works regardless of the actual status of the RGB Matrix.
Types of Changes
Issues Fixed or Closed by This PR
Checklist