Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup massdrop/alt, cest73/tkm. #14048

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fixup massdrop/alt, cest73/tkm. #14048

merged 3 commits into from
Aug 17, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 17, 2021 •
edited
Loading

Description

Bugfix for #12097 breaking massdrop/alt.
Bugfix for #13939 breaking due to bootmagic full.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Aug 17, 2021
@tzarc tzarc requested a review from a team August 17, 2021 20:02
@tzarc tzarc changed the title Fixup massdrop/alt. Fixup massdrop/alt, cest73/tkm. Aug 17, 2021
@tzarc tzarc changed the title Fixup massdrop/alt, cest73/tkm. Fixup massdrop/alt, cest73/tkm. Aug 17, 2021
noroadsleft
noroadsleft requested changes Aug 17, 2021
View reviewed changes
keyboards/cest73/tkm/rules.mk Outdated Show resolved Hide resolved
@tzarc @noroadsleft
Update keyboards/cest73/tkm/rules.mk
21d5e62 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@tzarc tzarc requested a review from noroadsleft August 17, 2021 20:42
@tzarc tzarc merged commit 8db1d22 into qmk:develop Aug 17, 2021
@tzarc tzarc deleted the fixup-12097 branch August 17, 2021 20:44
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@tzarc @noroadsleft @nhongooi
Fixup massdrop/alt, cest73/tkm. (qmk#14048)
44f278d 
* Fixup massdrop/alt.

* Fixup `cest73/tkm` bootmagic lite.

* Update keyboards/cest73/tkm/rules.mk

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @noroadsleft