Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HT32 support to core #14388

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Add HT32 support to core #14388

merged 6 commits into from
Oct 18, 2021

Conversation

bwisn
Copy link

@bwisn bwisn commented Sep 11, 2021 •
edited
Loading

Description

This adds HT32 support to QMK needed for the Anne Pro 2 keyboard (#14385)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 11, 2021
@bwisn bwisn mentioned this pull request Sep 11, 2021
Merged
14 tasks
@tzarc tzarc changed the base branch from master to develop September 12, 2021 06:13
@tzarc
Copy link
Member

tzarc commented Sep 12, 2021

Retargeted to develop due to core changes.

@bwisn
Copy link
Author

bwisn commented Sep 12, 2021

@drashna fixed

@drashna drashna requested a review from a team September 12, 2021 14:55
fauxpark
fauxpark requested changes Sep 12, 2021
View reviewed changes
platforms/chibios/drivers/spi_master.c Outdated Show resolved Hide resolved
tmk_core/protocol/chibios/usb_main.c Outdated Show resolved Hide resolved
tmk_core/protocol/chibios/usb_main.c Outdated Show resolved Hide resolved
tmk_core/protocol/chibios/usb_main.c Outdated Show resolved Hide resolved
tmk_core/protocol/chibios/usb_main.c Outdated Show resolved Hide resolved
platforms/chibios/drivers/spi_master.c Outdated Show resolved Hide resolved
platforms/chibios/drivers/spi_master.c Outdated Show resolved Hide resolved
@drashna drashna self-requested a review September 12, 2021 15:22
@bwisn bwisn requested a review from fauxpark September 12, 2021 17:34
bwisn and others added 5 commits September 15, 2021 22:11
@bwisn
tmk_core: temporary fix to allow HT32 based keyboards to work without…
447cf5a 
… patched ChibiOS-contrib (AnnePro2)
@tech2077 @bwisn
HT32: add spi support
13447af 
Add persistent led support with eeprom (OpenAnnePro#9)

* adding HT32 support to chibios SPI master driver

update spi driver, fix bad merging with master
@bwisn @drashna
HT32: fix formatting
977877d 
HT32: Fix formatting: tmk_core/protocol/chibios/usb_main.c

Co-authored-by: Drashna Jaelre <drashna@live.com>
@bwisn @fauxpark
HT32: Apply suggestions from fauxpark's code review
9d103ca 
Co-authored-by: Ryan <fauxpark@gmail.com>
@bwisn
HT32: update spi driver
37b6928
@bwisn bwisn requested a review from zvecr September 16, 2021 19:51
@tzarc
Copy link
Member

tzarc commented Sep 22, 2021

An Anne Pro 2 arrived this afternoon, will see what I can do.

@tzarc tzarc self-assigned this Sep 22, 2021
zvecr
zvecr approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spi_master.c changes are going to need some rework, so the platform specific logic is easier to maintain. However as this is also an issue with existing code, i see no reason to hold this PR up.

@bwisn
Copy link
Author

bwisn commented Oct 15, 2021

@tzarc friendly ping

@tzarc tzarc merged commit 7e3ff20 into qmk:develop Oct 18, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 19, 2021
Merge remote-tracking branch 'qmk/develop' into develop
c1d4d46 
* qmk/develop: (26 commits)
  [DOCS] Fix the STENO_COMBINEDMAP table (qmk#14883)
  Fix builds for ChibiOS + Cortex-M0[+] (qmk#14879)
  Split out HAPTIC_ENABLE to have separate DRIVER option (qmk#14854)
  [Core] Add support for RISC-V builds and GD32VF103 MCU (qmk#12508)
  Add HT32 support to core (qmk#14388)
  preonic/rev3_drop: Fix old custom matrix code (qmk#14857)
  Remove legacy Makefile functionality (qmk#14858)
  Infer more when building features (qmk#13890)
  [Keymap] added media controls, copy and paste; moved print screen (qmk#14850)
  [Keyboard] Add SpiderIsland 25 key keyboard (qmk#14793)
  [Keyboard] Update Support for The Uni (qmk#14569)
  Try to clarify "number of elements in info.json does not match" error (qmk#14844)
  [Keyboard] Fix minor typo in Ploopy Trackball Nano Docs (qmk#14717)
  add docs/ja/ja_doc_status.sh (qmk#14402)
  [Keyboard] Amended Some Pins - KiwiKeebs Macro V2 (qmk#14824)
  [Keyboard] Adding CK60 and CK65 (qmk#14737)
  [Keymap] Update Miryoku (qmk#14827)
  [Keymap] Drashna Keymap Updates (qmk#14842)
  [Keyboard] Tractyl Manuform Updates (qmk#14841)
  [Keymap] Added GMMK Pro keymap with RGB  (qmk#14648)
  ...
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@bwisn @tech2077
@drashna @fauxpark @ptrxyz
Add HT32 support to core (qmk#14388)
887dd98 
* tmk_core: temporary fix to allow HT32 based keyboards to work without patched ChibiOS-contrib (AnnePro2)

* HT32: add spi support

Add persistent led support with eeprom (qmk#9)

* adding HT32 support to chibios SPI master driver

update spi driver, fix bad merging with master

* HT32: fix formatting

HT32: Fix formatting: tmk_core/protocol/chibios/usb_main.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

* HT32: Apply suggestions from fauxpark's code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* HT32: update spi driver

* ht32: apply code review suggestions, remove old workaround

Co-authored-by: tech2077 <tech2077@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@bwisn @tech2077
@drashna @fauxpark
Add HT32 support to core (qmk#14388)
4362ddc 
* tmk_core: temporary fix to allow HT32 based keyboards to work without patched ChibiOS-contrib (AnnePro2)

* HT32: add spi support

Add persistent led support with eeprom (qmk#9)

* adding HT32 support to chibios SPI master driver

update spi driver, fix bad merging with master

* HT32: fix formatting

HT32: Fix formatting: tmk_core/protocol/chibios/usb_main.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

* HT32: Apply suggestions from fauxpark's code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* HT32: update spi driver

* ht32: apply code review suggestions, remove old workaround

Co-authored-by: tech2077 <tech2077@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees

@tzarc tzarc

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bwisn @tzarc @drashna @fauxpark @zvecr @tech2077