Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ChibiOS I2C defs with other drivers #14399

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 12, 2021

Description

The inconsistency has been bugging me for a while, theres little reason for it to be different than the other drivers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the feature/i2c_chibi_align branch from 0255c7d to 1e329ee Compare September 12, 2021 02:37
@drashna drashna requested a review from a team September 12, 2021 02:39
keyboards/xelus/valor_frl_tkl/config.h Outdated Show resolved Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
@zvecr zvecr requested a review from fauxpark September 12, 2021 12:03
@zvecr zvecr merged commit 0fa217a into qmk:develop Sep 12, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Align ChibiOS I2C defs with other drivers

* Update keyboards/xelus/valor_frl_tkl/config.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 3, 2022
* Align ChibiOS I2C defs with other drivers

* Update keyboards/xelus/valor_frl_tkl/config.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Align ChibiOS I2C defs with other drivers

* Update keyboards/xelus/valor_frl_tkl/config.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants