Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ChibiOS PAL interactions less STM32 specific #14439

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 15, 2021

Description

Coerce existing defines to hide STM32 context.

This then allows the concept to extend out to something like...

#if defined(HT32)
#    define PAL_MODE_ALTERNATE PAL_HT32_MODE_AF
#endif

And removing the need to litter the code base with various ifdefs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 15, 2021
@zvecr zvecr changed the title Refactor use of _STM32_ defines Make ChibiOS PAL interactions less STM32 specific Sep 15, 2021
@zvecr zvecr force-pushed the feature/chibios_stm_defines branch from d9489bc to 0787c6b Compare September 15, 2021 00:47
@zvecr zvecr requested review from tzarc and a team September 15, 2021 00:54
@zvecr zvecr marked this pull request as ready for review September 15, 2021 00:57
@tzarc tzarc requested a review from a team September 15, 2021 01:18
@tzarc tzarc merged commit a78f0e8 into qmk:develop Sep 15, 2021
drashna added a commit to drashna/qmk_firmware that referenced this pull request Sep 15, 2021
zvecr pushed a commit that referenced this pull request Sep 15, 2021
@drashna
Copy link
Member

drashna commented Sep 15, 2021

Oh fun, this looks like it's breaking my planck EZ. rgb doesn't work on it, neither do the keys. Or even the front LEDs (they're left floating)

ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants