Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic keycode overhaul #14726

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Basic keycode overhaul #14726

merged 5 commits into from
Nov 4, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 6, 2021

Description

  • Changed keycode references in docs to short aliases for brevity

  • Changed keycode references in core code to long forms for clarity

  • Renamed keycodes:

    Old Keycode New Keycode
    KC_BSPACE KC_BACKSPACE
    KC_LBRACKET KC_LEFT_BRACKET
    KC_RBRACKET KC_RIGHT_BRACKET
    KC_BSLASH KC_BACKSLASH
    KC_SCOLON KC_SEMICOLON
    KC_CAPSLOCK KC_CAPS_LOCK
    KC_PSCREEN KC_PRINT_SCREEN
    KC_SCROLLLOCK KC_SCROLL_LOCK
    KC_PGUP KC_PAGE_UP
    KC_PGDOWN KC_PAGE_DOWN
    KC_NUMLOCK KC_NUM_LOCK
    KC_NONUS_BSLASH KC_NONUS_BACKSLASH
    KC_POWER KC_KB_POWER
    KC__MUTE KC_KB_MUTE
    KC__VOLUP KC_KB_VOLUME_UP
    KC__VOLDOWN KC_KB_VOLUME_DOWN
    KC_LOCKING_CAPS KC_LOCKING_CAPS_LOCK
    KC_LOCKING_NUM KC_LOCKING_NUM_LOCK
    KC_LOCKING_SCROLL KC_LOCKING_SCROLL_LOCK
    KC_INT1 KC_INTERNATIONAL_1
    KC_INT2 KC_INTERNATIONAL_2
    KC_INT3 KC_INTERNATIONAL_3
    KC_INT4 KC_INTERNATIONAL_4
    KC_INT5 KC_INTERNATIONAL_5
    KC_INT6 KC_INTERNATIONAL_6
    KC_INT7 KC_INTERNATIONAL_7
    KC_INT8 KC_INTERNATIONAL_8
    KC_INT9 KC_INTERNATIONAL_9
    KC_LANG1 KC_LANGUAGE_1
    KC_LANG2 KC_LANGUAGE_2
    KC_LANG3 KC_LANGUAGE_3
    KC_LANG4 KC_LANGUAGE_4
    KC_LANG5 KC_LANGUAGE_5
    KC_LANG6 KC_LANGUAGE_6
    KC_LANG7 KC_LANGUAGE_7
    KC_LANG8 KC_LANGUAGE_8
    KC_LANG9 KC_LANGUAGE_9
    KC_ALT_ERASE KC_ALTERNATE_ERASE
    KC_SYSREQ KC_SYSTEM_REQUEST
    KC_LCTRL KC_LEFT_CTRL
    KC_LSHIFT KC_LEFT_SHIFT
    KC_LALT KC_LEFT_ALT
    KC_LGUI KC_LEFT_GUI
    KC_RCTRL KC_RIGHT_CTRL
    KC_RSHIFT KC_RIGHT_SHIFT
    KC_RALT KC_RIGHT_ALT
    KC_RGUI KC_RIGHT_GUI
  • Added aliases:

    Alias Keycode
    KC_SCRL KC_SCROLL_LOCK
    KC_PGUP KC_PAGE_UP
    KC_NUM KC_NUM_LOCK
    KC_INT1 KC_INTERNATIONAL_1
    KC_INT2 KC_INTERNATIONAL_2
    KC_INT3 KC_INTERNATIONAL_3
    KC_INT4 KC_INTERNATIONAL_4
    KC_INT5 KC_INTERNATIONAL_5
    KC_INT6 KC_INTERNATIONAL_6
    KC_INT7 KC_INTERNATIONAL_7
    KC_INT8 KC_INTERNATIONAL_8
    KC_INT9 KC_INTERNATIONAL_9
    KC_LNG1 KC_LANGUAGE_1
    KC_LNG2 KC_LANGUAGE_2
    KC_LNG3 KC_LANGUAGE_3
    KC_LNG4 KC_LANGUAGE_4
    KC_LNG5 KC_LANGUAGE_5
    KC_LNG6 KC_LANGUAGE_6
    KC_LNG7 KC_LANGUAGE_7
    KC_LNG8 KC_LANGUAGE_8
    KC_LNG9 KC_LANGUAGE_9
    KC_SYRQ KC_SYSTEM_REQUEST
    KC_CNCL KC_CANCEL
    KC_PRIR KC_PRIOR
    KC_RETN KC_RETURN
    KC_SEPR KC_SEPARATOR
    KC_CLAG KC_CLEAR_AGAIN
    KC_CRSL KC_CRSEL
    KC_EXSL KC_EXSEL
    KC_LALT KC_LEFT_ALT
    KC_LGUI KC_LEFT_GUI
    KC_RALT KC_RIGHT_ALT
    KC_RGUI KC_RIGHT_GUI
  • Removed aliases:

    Alias Replacement
    KC_CLCK KC_CAPS
    KC_SLCK KC_SCRL
    KC_NLCK KC_NUM
    KC_ZKHK JP_ZKHK
    KC_RO JP_BSLS
    KC_KANA JP_KANA
    KC_JYEN JP_YEN
    KC_HENK JP_HENK
    KC_MHEN JP_MHEN
    KC_HAEN KR_HAEN
    KC_HANJ KR_HANJ

Old keycodes are now housed in keycode_legacy.h, to be deleted at some point.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 7, 2021 02:17
@drashna drashna merged commit f529580 into qmk:develop Nov 4, 2021
@fauxpark fauxpark deleted the basic-keycode-overhaul branch November 4, 2021 05:53
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@fauxpark fauxpark mentioned this pull request Apr 25, 2022
14 tasks
noroadsleft added a commit to noroadsleft/qmk_configurator that referenced this pull request May 28, 2022
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Jul 5, 2022
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Sep 30, 2022
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Oct 18, 2022
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Dec 2, 2022
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Dec 14, 2022
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Jan 13, 2023
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request Feb 10, 2023
dead10ck added a commit to dead10ck/qmk_firmware that referenced this pull request May 6, 2023
mattpcaswell pushed a commit to mattpcaswell/qmk_firmware that referenced this pull request Jun 7, 2023
* Update Keycode List

Per qmk/qmk_firmware Pull Requests qmk#14726 & qmk#15968.

- change `KC_SLCK` to `KC_SCRL`
- change `KC_NLCK` to `KC_NUM`
- change `KC_RO` to `KC_INT1`
- change `KC_KANA` to `KC_INT2`
- change `KC_JYEN` to `KC_INT3`
- change `KC_HENK` to `KC_INT4`
- change `KC_MHEN` to `KC_INT5`
- change `KC_HAEN` to `KC_LNG1`
- change `KC_HANJ` to `KC_LNG2`
- change `RESET` to `QK_BOOT`
- change `DEBUG` to `DB_TOGG`
- change `EEP_RST` to `EE_CLR`
- change `KC_GESC` to `QK_GESC`

* update keymaps to use KC_SCRL

* update keymaps to use KC_NUM

* update keymaps to use KC_INT1

* update keymaps to use KC_INT2

* update keymaps to use KC_INT3

* update keymaps to use KC_INT4

* update keymaps to use KC_INT5

* update keymaps to use KC_LNG1

* update keymaps to use KC_LNG2

* update keymaps to use QK_BOOT, 0-9

* update keymaps to use QK_BOOT, A

* update keymaps to use QK_BOOT, B

* update keymaps to use QK_BOOT, C

* update keymaps to use QK_BOOT, D

* update keymaps to use QK_BOOT, E

* update keymaps to use QK_BOOT, F-G

* update keymaps to use QK_BOOT, H

* update keymaps to use QK_BOOT, I-J

* update keymaps to use QK_BOOT, K

* update keymaps to use QK_BOOT, L

* update keymaps to use QK_BOOT, M

* update keymaps to use QK_BOOT, N-O

* update keymaps to use QK_BOOT, P-Q

* update keymaps to use QK_BOOT, R

* update keymaps to use QK_BOOT, S

* update keymaps to use QK_BOOT, T-V

* update keymaps to use QK_BOOT, W-X

* update keymaps to use QK_BOOT, Y-Z

* update keymaps to use DB_TOGG

* update keymaps to use EE_CLR

* update keymaps to use QK_GESC, 0-9 & A-D

* update keymaps to use QK_GESC, E-J

* update keymaps to use QK_GESC, K-L

* update keymaps to use QK_GESC, M-P

* update keymaps to use QK_GESC, R-Z

* update keycode list in keyboard tester
ibudiselic added a commit to ibudiselic/qmk_firmware that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants