Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new led driver for Keychron's keyboards. #14872

Merged
merged 18 commits into from
Nov 1, 2021
Merged

Add a new led driver for Keychron's keyboards. #14872

merged 18 commits into from
Nov 1, 2021

Conversation

KeychronMacro
Copy link
Contributor

Description

Add a new led driver for Keychron's keyboards.
New led driver files: ckled2001.c, ckled2001.h.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member

Pleas stop opening new PRs.

@KeychronMacro KeychronMacro reopened this Oct 18, 2021
@drashna
Copy link
Member

drashna commented Oct 23, 2021

The changes to the submodules needs to be reverted.

@tzarc tzarc requested a review from a team October 28, 2021 04:16
@tzarc tzarc merged commit f4ea262 into qmk:develop Nov 1, 2021
@vinorodrigues vinorodrigues mentioned this pull request Jan 23, 2022
Closed
14 tasks
@vinorodrigues vinorodrigues mentioned this pull request Jan 26, 2022
Merged
14 tasks
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@KeychronMacro @keychron-dev
@lokher @ptrxyz
Add a new led driver for Keychron's keyboards. (qmk#14872)
6055a3a 
* Add a new led driver for Keychron's keyboards.

* Update ckled2001.c/ckled2001.h.

* Update ckled2001.c/ckled2001.h.

* Update ckled2001.c/ckled2001.h.

* Update ckled2001.c

* Add a new led driver

* Update ckled2001.c

* Update ckled2001.c

* Update ckled2001.c

* Update ckled2001.c

* Delete ckled2001.c

* Create ckled2001.c

* Update ckled2001.c

* Update chibios-contrib

Co-authored-by: keychron-dev <85598583+keychron-dev@users.noreply.github.com>
Co-authored-by: lokher <lokher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KeychronMacro @fauxpark @drashna @tzarc @keychron-dev @lokher