Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bm65hsrgb/rev2 #15060

Closed
wants to merge 2 commits into from
Closed

Add bm65hsrgb/rev2 #15060

wants to merge 2 commits into from

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Nov 5, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee peepeetee marked this pull request as draft November 5, 2021 07:58
@sigprof sigprof mentioned this pull request Nov 6, 2021
Closed
@peepeetee peepeetee marked this pull request as ready for review November 10, 2021 05:08
drashna
drashna requested changes Nov 10, 2021
View reviewed changes
keyboards/kprepublic/bm65rgb/rev2/rev2.h Outdated Show resolved Hide resolved
@peepeetee peepeetee requested a review from drashna November 11, 2021 01:13
@rotaryking
Copy link

rotaryking commented Nov 13, 2021 •
edited
Loading

After flashing on my BM65V2, it works successfully
rip ppt's pcb

@peepeetee peepeetee marked this pull request as draft November 16, 2021 15:14
@peepeetee peepeetee changed the title Add BM65RGB/rev2 Add bm65hsrgb/rev2 Nov 19, 2021
@peepeetee peepeetee changed the base branch from master to develop November 19, 2021 06:53
@peepeetee peepeetee marked this pull request as ready for review November 19, 2021 07:07
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Nov 22, 2021
@peepeetee peepeetee changed the base branch from develop to master November 28, 2021 01:04
@drashna drashna requested a review from a team November 28, 2021 06:07
@peepeetee peepeetee mentioned this pull request Dec 6, 2021
Closed
@rotaryking
Copy link

image
error within rev2.c

@peepeetee
Copy link
Contributor Author

@rotaryking compiles fine after my latest commit,
image
image

@peepeetee peepeetee requested a review from fauxpark December 24, 2021 04:24
@peepeetee peepeetee requested a review from drashna December 25, 2021 02:12
@peepeetee peepeetee requested a review from fauxpark February 8, 2022 07:23
@peepeetee
Copy link
Contributor Author

Rebased just now, should have resolved the conflicts

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 27, 2022
@drashna
Copy link
Member

drashna commented Jul 2, 2022

☒ kprepublic/bm65hsrgb/rev2: NO_ACTION_MACRO in config.h is no longer a valid option
☒ kprepublic/bm65hsrgb/rev2: NO_ACTION_FUNCTION in config.h is no longer a valid option

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 17, 2022
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Sep 17, 2022
@CerebroJD
Copy link

Is there an opportunity to get these changes merged into qmk so these v2 boards are supported?

@chigzy
Copy link

chigzy commented Mar 14, 2023

What’s remaining for this?
Anywhere to help?

@peepeetee
Copy link
Contributor Author

What’s remaining for this? Anywhere to help?

just had to poke me, and you did

@fauxpark fauxpark reopened this Mar 15, 2023
@github-actions github-actions bot added core documentation translation and removed stale Issues or pull requests that have become inactive without resolution. labels Mar 15, 2023
@noroadsleft
Copy link
Member

This PR needs to be rebased upon a current qmk:master – there are a lot of merge conflicts, which makes this unable to be merged.

@peepeetee
Copy link
Contributor Author

This PR needs to be rebased upon a current qmk:master – there are a lot of merge conflicts, which makes this unable to be merged.

I need to undo b67c072 and rebase on master instead. how would I do that?

drashna
drashna reviewed May 3, 2023
View reviewed changes
keyboards/kprepublic/bm65hsrgb/rev2/config.h
Comment on lines +24 to +50

/* USB Device descriptor parameter */
// #define VENDOR_ID 0x4B50 //KP
// #define PRODUCT_ID 0x1133
// #define DEVICE_VER 0x0002
// #define MANUFACTURER KPRepublic
// #define PRODUCT BM65 RGB

/* key matrix size */
// #define MATRIX_ROWS 5
// #define MATRIX_COLS 15

/*
* Keyboard Matrix Assignments
*
* Change this to how you wired your keyboard
* COLS: AVR pins used for columns, left to right
* ROWS: AVR pins used for rows, top to bottom
* DIODE_DIRECTION: COL2ROW = COL = Anode (+), ROW = Cathode (-, marked on diode)
* ROW2COL = ROW = Anode (+), COL = Cathode (-, marked on diode)
*
*/

// #define UNUSED_PINS

/* COL2ROW, ROW2COL */
//#define DIODE_DIRECTION COL2ROW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed, not just commented out.

keyboards/kprepublic/bm65hsrgb/rev2/config.h
Comment on lines +52 to +57
// The pin connected to the data pin of the LEDs
#define RGB_DI_PIN E2
// The number of LEDs connected
#define DRIVER_LED_TOTAL 73
#ifdef RGB_DI_PIN
#define RGBLED_NUM 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These may need to be updated.

@lesshonor lesshonor mentioned this pull request May 18, 2023
Closed
14 tasks
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 17, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jul 17, 2023
@gab-gil
Copy link

gab-gil commented Nov 3, 2023

Any updates on this? Just got myself a BM65V2 and I want to change the backlight's LED's color

@zniqco zniqco mentioned this pull request Sep 3, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
core documentation keyboard keymap stale Issues or pull requests that have become inactive without resolution. translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@peepeetee @rotaryking @4itor @drashna @CerebroJD @chigzy @noroadsleft @gab-gil @fauxpark