IS31FL3733 driver for LED Matrix #15088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myst729
force-pushed
the
is3733-led-matrix
branch
2 times, most recently
from
605b478 to
f2cfe79
Compare
|
This would need to target develop. |
myst729
changed the title
myst729
force-pushed
the
is3733-led-matrix
branch
2 times, most recently
from
66dd4fd to
b8cfda8
Compare
myst729
force-pushed
the
is3733-led-matrix
branch
from
b8cfda8 to
9266736
Compare
myst729
changed the title
|
Edited to branch from |
tzarc
approved these changes
Dec 27, 2021
drashna
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After reading source code of LED matrix, I noticed that the work for supporting IS31FL3733 has partially done. But I've no idea why it wasn't finished since then.
I port an IS31FL3733 driver for LED matrix, almost the same way as how IS31FL3731 was ported. Simply add following lines in
rules.mkto use it:The documentation needs to be updated accordingly, could be highly similar to IS31FL3731 section though.
Types of Changes
Issues Fixed or Closed by This PR
Checklist