Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc10 LTO - Only specify adhlns assembler options at link time #15115

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 11, 2021

Description

Resolves the long standing issue of,

Making lets_split/sockets with keymap default                                                          [WARNINGS]
 | 
 | lto-wrapper: warning: Options to Xassembler do not match: -adhlns=.build/obj_lets_split_sockets_default/keyboards/lets_split/lets_split.lst, -adhlns=.build/obj_lets_split_sockets_default/keyboards/lets_split/sockets/sockets.lst, dropping all -Xassembler and -Wa options.
 |

447ec8f - Do the vast majority of users actually care about these files? Seems like it should be opt-in (which also removes an additional clang check).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Nov 11, 2021
@zvecr zvecr requested a review from a team November 11, 2021 04:05
@github-actions github-actions bot added the core label Nov 11, 2021
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an opt-in by default. 👍

@tzarc tzarc merged commit f3fa56c into qmk:develop Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants