Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KPrepublic BM60hsrgb/rev2, acting in lieu of @bdtc123 #15177

Merged
merged 11 commits into from
Dec 11, 2021
Merged

Add KPrepublic BM60hsrgb/rev2, acting in lieu of @bdtc123 #15177

merged 11 commits into from
Dec 11, 2021

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Nov 16, 2021 •
edited
Loading

Description

I've been asked by @bdtc123 to upload their code to qmk, and this is one of the keyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 16, 2021
@peepeetee peepeetee marked this pull request as draft November 16, 2021 15:15
@peepeetee
Copy link
Contributor Author

I need help making heads and tails of the RGB code to merge the keymap with the existing keymap in BM60RGB's keymap folder. How should I proceed?

@github-actions github-actions bot removed the via Adds via keymap and/or updates keyboard for via support label Nov 17, 2021
@peepeetee peepeetee closed this Nov 17, 2021
@peepeetee peepeetee reopened this Nov 17, 2021
@peepeetee peepeetee marked this pull request as ready for review November 17, 2021 03:43
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Nov 17, 2021
@peepeetee
Copy link
Contributor Author

I need help making heads and tails of the RGB code to merge the keymap with the existing keymap in BM60RGB's keymap folder. How should I proceed?

resolved, thanks

@drashna drashna requested a review from a team November 19, 2021 06:01
fauxpark
fauxpark requested changes Nov 19, 2021
View reviewed changes
keyboards/kprepublic/bm60hsrgb/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb/rev2/rev2.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb/rev2/info.json Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb/rev2/rev2.c Outdated Show resolved Hide resolved
peepeetee and others added 3 commits November 19, 2021 19:03
@peepeetee peepeetee changed the base branch from develop to master November 28, 2021 01:02
@drashna drashna requested a review from a team November 28, 2021 05:35
@peepeetee peepeetee requested review from fauxpark and removed request for a team November 28, 2021 16:19
@peepeetee peepeetee mentioned this pull request Dec 6, 2021
Closed
@peepeetee @fauxpark
Update keyboards/kprepublic/bm60hsrgb/rev2/config.h
1e5fdaa 
Co-authored-by: Ryan <fauxpark@gmail.com>
@peepeetee @fauxpark
Update keyboards/kprepublic/bm60hsrgb/readme.md
c397b8a 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 9294258 into qmk:master Dec 11, 2021
@peepeetee peepeetee mentioned this pull request Feb 3, 2022
Merged
6 tasks
@rgoulter rgoulter mentioned this pull request Mar 19, 2022
Merged
14 tasks
@TheChilledDejw TheChilledDejw mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filterpaper filterpaper filterpaper requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peepeetee @drashna @fauxpark @filterpaper