Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WB32F3G71 config migration with removal of unnecessary items. #15309

Merged
merged 2 commits into from
Nov 26, 2021
Merged

WB32F3G71 config migration with removal of unnecessary items. #15309

merged 2 commits into from
Nov 26, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Nov 26, 2021

Description

WB32F3G71 support had unnecessary config formats which would prevent ChibiOS upgrade.
@wb-Joy would be nice if you could confirm that these work.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team November 26, 2021 22:34
@github-actions github-actions bot added the core label Nov 26, 2021
itarze
itarze reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@itarze itarze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both files can be deleted，The chconf configuration is default.

@tzarc
Copy link
Member Author

tzarc commented Nov 26, 2021

Both files can be deleted，The chconf configuration is default.

Thanks for confirmation.

@tzarc tzarc merged commit 94d7cc3 into qmk:develop Nov 26, 2021
@tzarc tzarc deleted the wb32-cutdown-configs branch November 26, 2021 23:35
@itarze
Copy link
Contributor

itarze commented Nov 30, 2021

I made a mistake, The value of CH_CFG_ST_TIMEDELTA must be 0.

@tzarc
Copy link
Member Author

tzarc commented Nov 30, 2021

Please make a new bugfix PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itarze itarze itarze approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @itarze @drashna