Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added external spi flash driver. #15419

Merged
merged 38 commits into from
Feb 11, 2022
Merged

Added external spi flash driver. #15419

merged 38 commits into from
Feb 11, 2022

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Dec 7, 2021 •
edited
Loading

Added external spi flash driver.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 7, 2021
@tzarc tzarc added the needs doc label Dec 7, 2021
@itarze
Copy link
Contributor Author

itarze commented Dec 7, 2021

@tzarc Describe where the document should be added?

@drashna
Copy link
Member

drashna commented Dec 7, 2021

presumably: https://github.com/qmk/qmk_firmware/blob/develop/docs/eeprom_driver.md

@tzarc
Copy link
Member

tzarc commented Dec 7, 2021

Almost, will need a flash_driver.md with descriptions of configurable items, as well as a link to the new page in the sidebar.

@drashna
Copy link
Member

drashna commented Dec 7, 2021

Almost, will need a flash_driver.md with descriptions of configurable items, as well as a link to the new page in the sidebar.

I should read more. But should be set up somewhat similarly, I think. At least in the sidebar for the docs, and such.

@itarze itarze force-pushed the develop_for_spi_flash branch from 413321c to d6f89b7 Compare December 7, 2021 06:21
@tzarc tzarc self-assigned this Dec 7, 2021
@drashna drashna requested a review from a team December 18, 2021 02:58
tzarc
tzarc requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, all the "Kbyte" values have been converted to "byte", please confirm with hardware.

docs/ja/_summary.md Outdated Show resolved Hide resolved
docs/zh-cn/_summary.md Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Feb 8, 2022

Please also confirm that usages of uintptr_t have been changed to uint32_t.

Joy Lee and others added 9 commits February 9, 2022 09:06
@tzarc
Update drivers/flash/flash_spi.h
69e167f 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
bc72ce2 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
1211426 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.h
8e7c2ae 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.h
4d51073 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.h
762ba45 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
9c5b198 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
21cb1ff 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Revert docs.
de1b9f4
Joy Lee and others added 13 commits February 9, 2022 09:30
@tzarc
Update docs/flash_driver.md
a06f14e 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
b34e048 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
20a59a3 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
2466ffd 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
5e81862 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.h
b3647d9 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.h
ef65275 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.h
10b83e5 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Modified code format.
cb46b3d
Update drivers/flash/flash_spi.c
fd58d30
Modified code format.
734fefd
Update docs/flash_driver.md
ba823f5
Update drivers/flash/flash_spi.h
e6c4eb0
@itarze itarze requested a review from tzarc February 9, 2022 02:29
tzarc
tzarc requested changes Feb 9, 2022
View reviewed changes
common_features.mk Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
Joy Lee and others added 7 commits February 9, 2022 10:40
@tzarc
Update common_features.mk
cb78267 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
cc66dc4 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
b64de27 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
9c7c4f1 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
54e3886 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
8b24ee5 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc
Update drivers/flash/flash_spi.c
ab63b20 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc tzarc requested a review from a team February 9, 2022 03:43
@zvecr zvecr merged commit 71c0b97 into qmk:develop Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

Assignees

@tzarc tzarc

Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itarze @drashna @tzarc @zvecr