Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] MelGeek Mach80 rev2 #15610

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[Keyboard] MelGeek Mach80 rev2 #15610

merged 1 commit into from
Feb 9, 2022

Conversation

mj-bomb
Copy link

@mj-bomb mj-bomb commented Dec 28, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mj-bomb mj-bomb changed the title Split layout due to incompatible lamp effect! Split layout due to incompatible lamp effect! -melgeek/mach80 Dec 28, 2021
@noroadsleft noroadsleft changed the title Split layout due to incompatible lamp effect! -melgeek/mach80 [Keyboard] MelGeek Mach80 rev2 Feb 8, 2022
noroadsleft
noroadsleft approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team February 8, 2022 02:10
@drashna drashna merged commit a75fb03 into qmk:master Feb 9, 2022
@mj-bomb mj-bomb deleted the melgeek_mach80_wkl branch February 9, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj-bomb @drashna @noroadsleft