Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move @kkatano 's keyboards to kkatano user folder #15684

Merged
merged 4 commits into from
Jan 30, 2022
Merged

move @kkatano 's keyboards to kkatano user folder #15684

merged 4 commits into from
Jan 30, 2022

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Dec 31, 2021 •
edited
Loading

Description

Boards moved:

  • bakeneko60
  • bakeneko65
  • bakeneko80
  • wallaby
  • yurei

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 31, 2021
@peepeetee peepeetee changed the title move @kkatano 's bakeneko* to kkatano user folder move @kkatano 's keyboards to kkatano user folder Dec 31, 2021
@peepeetee peepeetee mentioned this pull request Jan 1, 2022
Closed
@drashna drashna requested a review from a team January 2, 2022 08:04
noroadsleft
noroadsleft requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • keyboards/kkatano/bakeneko65/rev3/readme.md doesn't reference the new directory in the make instructions.

@peepeetee
Copy link
Contributor Author

  • keyboards/kkatano/bakeneko65/rev3/readme.md doesn't reference the new directory in the make instructions.

fixed

@drashna
Copy link
Member

drashna commented Jan 14, 2022

Can you verify that all of the effected keyboards compile properly? Both the default and via keymaps?

@peepeetee
Copy link
Contributor Author

Can you verify that all of the effected keyboards compile properly? Both the default and via keymaps?

Just rechecked
image

@drashna drashna requested a review from a team January 14, 2022 04:52
@peepeetee peepeetee requested a review from noroadsleft January 15, 2022 10:42
@drashna drashna merged commit 07bb653 into qmk:develop Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peepeetee @drashna @fauxpark @noroadsleft