Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]zh-cn document translate: ISP flashing #15716

Closed
wants to merge 6 commits into from
Closed

[Docs]zh-cn document translate: ISP flashing #15716

wants to merge 6 commits into from

Conversation

epiciskandar
Copy link

  • isp flashing

Description

following after PR #14924

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@epiciskandar epiciskandar mentioned this pull request Jan 3, 2022
Open
peepeetee
peepeetee suggested changes Jan 3, 2022
View reviewed changes
docs/zh-cn/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/zh-cn/isp_flashing_guide.md Outdated Show resolved Hide resolved
@daskygit
Copy link
Member

Could you include this change please? #15898 it'd likely be merged before this anyway.

epiciskandar and others added 3 commits February 2, 2022 22:45
@epiciskandar
zh-cn document translate
ee17ed8 
* isp flashing
@epiciskandar @peepeetee
Apply suggestions from code review
9c1eda7 
typo and accurating description

Co-authored-by: peepeetee <43021794+peepeetee@users.noreply.github.com>
@epiciskandar @peepeetee
Add doc tag version
7482543 
Co-authored-by: peepeetee <43021794+peepeetee@users.noreply.github.com>
@github-actions github-actions bot added cli qmk cli command core keyboard keymap python via Adds via keymap and/or updates keyboard for via support labels Feb 2, 2022
@epiciskandar epiciskandar marked this pull request as draft February 2, 2022 15:40
@epiciskandar epiciskandar force-pushed the zh-cn-doc-isp-flashing branch from 0bcd076 to 7482543 Compare February 2, 2022 15:42
@github-actions github-actions bot removed cli qmk cli command keyboard core python via Adds via keymap and/or updates keyboard for via support keymap labels Feb 2, 2022
@epiciskandar epiciskandar marked this pull request as ready for review February 2, 2022 15:51
@epiciskandar
Copy link
Author

epiciskandar commented Feb 5, 2022 •
edited
Loading

Could you include this change please? #15898

It has been includede now.

@stale
Copy link

stale bot commented Apr 16, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@epiciskandar
Copy link
Author

keep this

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peepeetee peepeetee peepeetee requested changes

Assignees
No one assigned
Labels
awaiting changes documentation stale Issues or pull requests that have become inactive without resolution. translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epiciskandar @daskygit @peepeetee